Repository navigation
List every crew on /crews, and rank only crews of two or more - #116
Merged
Merged
Conversation
A crew with one member was hidden from the board, so a new crew looked like it had vanished and an open crew looking for people could not be found. Every live crew is now listed: crews of two or more are ranked by ships as before, and the rest follow without a number, newest first, each saying how many more members it needs to rank.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/crewsused to hide any crew with fewer than 2 members. A crew you'd just started looked like it had vanished, and an open crew looking for people couldn't be found, so the first crew, ship happens, didn't show at all.Now:
N crews · M rankedwhile some crews are unranked.The 2-member minimum now applies only to rank numbers, so one person can't take #1 alone.
Tests:
crews.mjsscenario (a crew of one is listed, unranked, saying what it needs) failed on main and passes here.npm testpasses 149/149 and the server typecheck is clean.Server-only, no migration.