Repository navigation
Conversation
Author
|
Closing — keeping these fixes local rather than upstreaming. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #124 (that one flushes after a reap; this covers the case it can't see).
Problem
A settled session is submitted by its clean end. When those flushes all fail for a window — a burst of endcards meeting the rate limiter is enough — nothing ever retriggers: there is no later clean end until the user next closes a session, and desktop sessions can stay open for days. Real incident: nine finished sessions carrying 133 commits sat unsubmitted for ~22 hours; the leaderboard never moved.
#124 narrows this for reaped sessions, but sessions that finalized cleanly and failed to upload have no trigger at all.
Fix
submitProgressalready ticks onto the network every few minutes for a live shipped session. It now also runsflushPendingSubmissionson that tick (same throttle, same budget), so any live session — shipped or not — drains whatever settled work is stuck. An empty queue costs nothing: the flush resolves auth locally and returns before touching the network.The momentum and signature early-returns now gate only this session's own in-progress submit; the queue drain runs first, so settled work goes out even when this session has nothing new to say.
Tests
test/flush-on-tick.test.mjs(3 cases): a due tick sends a settled session that missed its clean end; a tick inside the throttle window drains nothing; a shipped session whose signature is unchanged still carries the queue while its own submit stays deduped.