Repository navigation
Conversation
This was referenced Oct 21, 2026
Owner
|
Checked this against the #122 notes: the no-op repair now leaves the file alone (bytes and mtime), and odd shapes are left untouched instead of throwing. The mixed group handling is a nice addition. Only nit: a valid file with an unexpected shape says "not valid JSON", which might confuse someone. Good to go once #129 is in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZCode desktop sessions do not run the shell wrappers, so Vibetime never sees them. This adds ZCode to the desktop hook lifecycle and includes the fixes from #122.
~/.zcode/cli/config.jsonalongside the existing desktop integrations.sess_<uuid>IDs and ignore sub-agent IDs to prevent duplicate sessions.Validation: the complete local suite passes 160/160. Tests cover merging, idempotency, saved approval, replacement, removal, invalid/unsupported configuration, fresh configuration, ID normalization and sub-agent exclusion. Added regressions verify no write on a matching enabled config and preservation of mixed groups; all three new regressions fail against the previous PR head.
The earlier macOS live verification is recorded in #122. This review reruns automated tests and does not claim a fresh ZCode desktop check. Windows and Linux desktop acceptance remain unverified.
Combined validation: all three revised branches merge cleanly in the order below and pass 192/192 local tests together.
Merge order: 1. #127 (storage) → 2. #129 (delivery) → 3. #128 (this PR). This replaces the closed #122.