Repository navigation
IBX-12891: Made the encore configs compatible with @symfony/webpack-encore 7 - #2164
Open
pawlakadrian wants to merge 1 commit into
Open
pawlakadrian wants to merge 1 commit into
pawlakadrian wants to merge 1 commit into
Conversation
This was referenced Oct 16, 2026
pawlakadrian
marked this pull request as ready for review
October 16, 2026 14:40
…ncore 7 @symfony/webpack-encore 7 is an ES module and getWebpackConfig() returns a Promise. The configs now resolve the module either way and modify the webpack config once it is ready, so they keep working unchanged with encore 5 while supporting encore 7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pawlakadrian
force-pushed
the
IBX-12891
branch
from
October 20, 2026 13:04
8a39586 to
1c9850d
Compare
|
ibexa-workflow-automation-1
Bot
requested review from
GrabowskiM,
OstafinL,
albozek,
alekmick,
dew326 and
tischsoic
and removed request for
a team
October 21, 2026 07:11
OstafinL
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Part of upgrading
@symfony/webpack-encoreto 7.x on 6.0 (4.6 and 5.0 stay on their encore version and keep the webpack<5.112.0pin from IBX-12890). Encore 7 is an ES module (require()returns{ default: Encore }) andgetWebpackConfig()returns a Promise, so modifying its result synchronously (config.name = ...,module.rules, config managers) is silently lost.This makes the encore config of this package work with both encore 5 and 7:
ibexa.webpack.libs.config.js: resolves encore withm.__esModule ? m.default : m(the encore 5 proxy exits on unknown properties likedefault, but allows__esModule) and sets thereact/reactDOMconfig names once the config is ready.With encore 5 the behaviour is unchanged: the config is still returned synchronously, so 5.0 projects and 6.0 projects still on encore 5 are not affected.
For QA:
Verified locally on commerce 5.0 and 6.0 projects, all six
ibexa:encore:compilesteps from CI plusencore production:Not verified in a browser yet; browser-tests regression run on 6.0: ibexa/commerce#2074.
Documentation:
🤖 Generated with Claude Code