Skip to content

IBX-12891: Made the encore configs compatible with @symfony/webpack-encore 7 #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pawlakadrian wants to merge 1 commit into
base: 6.0
Choose a base branch
from
Open

IBX-12891: Made the encore configs compatible with @symfony/webpack-encore 7 #372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions src/bundle/Resources/encore/ibexa.webpack.richtext.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ const path = require('path');
const ibexaConfigManager = require('@ibexa/frontend-config/webpack-config/manager');
const configManagers = require(path.resolve('./var/encore/ibexa.richtext.config.manager.js'));

// @symfony/webpack-encore 7+ returns the webpack config as a Promise, older versions return it directly
const whenConfigReady = (config, callback) => (typeof config?.then === 'function' ? config.then(callback) : callback(config));

module.exports = (Encore) => {
Encore.reset();
Encore.setOutputPath('public/assets/richtext/build')
Expand All @@ -11,11 +14,7 @@ module.exports = (Encore) => {
tsConfig.configFile = path.resolve('tsconfig.json');
tsConfig.onlyCompileBundledFiles = true;
})
.disableSingleRuntimeChunk()
.configureBabelPresetEnv((config) => {
config.useBuiltIns = false;
config.corejs = false;
});
.disableSingleRuntimeChunk();

Encore.addAliases({
'@ckeditor': path.resolve('./public/bundles/ibexaadminuiassets/vendors/@ckeditor'),
Expand All @@ -33,17 +32,19 @@ module.exports = (Encore) => {
path.resolve(__dirname, '../public/scss/ckeditor.scss'),
]);

const customConfig = Encore.getWebpackConfig();
const customConfig = whenConfigReady(Encore.getWebpackConfig(), (config) => {
config.name = 'richtext';

customConfig.name = 'richtext';
config.module.rules[4].oneOf[1].use[1].options.url = false;
config.module.rules[1].oneOf[1].use[1].options.url = false;

customConfig.module.rules[4].oneOf[1].use[1].options.url = false;
customConfig.module.rules[1].oneOf[1].use[1].options.url = false;
configManagers.forEach((configManagerPath) => {
const configManager = require(path.resolve(configManagerPath));

configManagers.forEach((configManagerPath) => {
const configManager = require(path.resolve(configManagerPath));
configManager(config, ibexaConfigManager);
});

configManager(customConfig, ibexaConfigManager);
return config;
});

Encore.reset();
Expand Down
Loading