AA Monorepo

[CadenLee2]

Summary

Introduces AntAlmanac Planner as part of the AntAlmanac repository. The entirety of Scheduler and Planner are now run and deployed as a singular Next.js app. Aside from very few exceptions (see below), the site's behavior should be unchanged.

Structure

The project is now reorganized into:

apps/
    antalmanac/
        (AntAlmanac root Next.js app. Defines app routing and public assets; re-exports from Scheduler and Planner)
    antalmanac-planner/
        (Originally the PeterPortal code)
    antalmanac-scheduler/
        db/
            (Originally packages/db)
        site/
            (Originally apps/antalmanac)
        types/
            (Originally packages/types)
packages/
    anteater-api/
        (Scheduler API types. Will be unified in a future PR)

Planner has already migrated to Next.js routing so minimal changes were needed on the Planner side aside from formatting.

Major code changes:

• Added Planner to the workspace (along with all its commits) and reorganized files (see structure above)
• Exported app and API routes for both apps from antalmanac (auth is still separate)
• Added Planner env vars. Some vars have been renamed for clarity (e.g. PLANNER_DB_URL)
• Updated GitHub actions and SST to match the new structure. AntAlmanac Router is still included (so that the prod deploy will have zero downtime; tested this on staging-shared)

Known changes in behavior

Aside from these specific changes, behavior should be identical:

• PostHog autocapture is no longer enabled on Planner (as we had discussed earlier; we can change this if desired)
• Drop shadow on Planner switcher is removed
• Public planner/* files are now accessed by planner-public/ (avoids OpenNext public folder name collision from overriding planner)
  • planner/robots.txt no longer exists
• Planner contributor graph now shows AntAlmanac contributors (as PeterPortal commits are included here, the graph should update once this PR is merged)

Contributor experience

• .env is now in apps/antalmanac and requires variables for both apps
• Commands are updated to remove ambiguity (e.g. plan:db:generate for the planner DB)
• Readme coming soon (Monorepo README #1962 ), docs coming soon
• GitHub repository has new templates, and labels to separate Scheduler/Planner tasks; issues will be ported from the PeterPortal repo
• Stagings are now staging- rather than scheduler-

Test Plan

• Auth (incl. shared auth cookie) works across apps
• PostHog works on planner
• Navigation between both apps is smooth
• Behavior in both apps is unchanged
  • Cross-app integrations work (e.g. search by planner)
  • All relative links in planner work (since there is no longer a base path)
  • All full-stack features work
  • Metadata/SEO all remains correct
• AANTS and PWA continue to function with no changes

Future followup

Non-exhaustive list of tasks:

• Straightforward code unification (e.g. shared components, Anteater API types)
• Unify auth
• Unify databases (e.g. for auth)
• Remove PLANNER_CLIENT_API_KEY
• Consolidate/rename for consistency: env variable names, names of workspace packages, and tsconfigs
• Offer a local docker db for Planner like Scheduler

[cubic-dev-ai]

29 issues found across 912 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/antalmanac-planner/api/src/controllers/courseMaterials.ts">

<violation number="1" location="apps/antalmanac-planner/api/src/controllers/courseMaterials.ts:16">
P2: `number` is accepted as any string but inserted raw into the query, so reserved characters can change or truncate the upstream request. Encode it in both procedures or build the query with `URLSearchParams`.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/component/InfiniteScrollContainer/InfiniteScrollContainer.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/component/InfiniteScrollContainer/InfiniteScrollContainer.tsx:34">
P2: This compares saved-course length with the stale search-result count, so scrolling saved courses can request another page for a cleared query. Pass whether these are paginated search results and set `hasMore` false for saved courses.</violation>
</file>

<file name="apps/antalmanac-planner/api/scripts/transfersRoadmapMajorMinorData.ts">

<violation number="1" location="apps/antalmanac-planner/api/scripts/transfersRoadmapMajorMinorData.ts:66">
P2: This comment claims the inserts are commented out, but the `tx.insert(userMajor)` block below actually executes and writes to the database. Either comment out the mutation blocks or remove the misleading comment; as written, a script runner will expect no data to change.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/roadmap/catalog/CatalogYears.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/roadmap/catalog/CatalogYears.tsx:21">
P2: This state never follows later `catalogYear` prop changes, so saved-year hydration can leave the control showing the default and confirming can overwrite the saved year. Synchronize the draft with the prop or initialize it when editing begins.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/roadmap/catalog/MajorCourseList.scss">

<violation number="1" location="apps/antalmanac-planner/site/src/app/roadmap/catalog/MajorCourseList.scss:39">
P2: `margin-bottom: 12;` is unitless and invalid CSS, so the declaration is dropped. Add the `px` unit.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/course/CoursePage.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/course/CoursePage.tsx:38">
P2: Both the error and the loading branches here are unreachable, so a failed course lookup renders placeholder data forever instead of any error or loading feedback. `error` is initialized to `''` and only ever assigned `''` (`setError('')`), and `useCourseData` never returns a falsy value — it returns `LOADING_COURSE_PLACEHOLDER` (a full `CourseGQLData` object) while loading and keeps it on fetch failure (see `src/hooks/catalog.ts`). The `if (error)` and `else if (!courseGQLData)` guards can never fire. Either surface a real error from the hook (and check `courseGQLData.id === LOADING_COURSE_PLACEHOLDER.id` for loading, as `CoursePreview.tsx` does), or remove these dead branches so the intended states are actually reachable.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/roadmap/search/ProfessorResult.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/roadmap/search/ProfessorResult.tsx:26">
P2: Both click handlers prevent the browser's modified-click behavior, so Ctrl/Cmd-click opens the preview in the current tab instead of opening the detail link in a new tab. Prevent default only for an unmodified primary click in both handlers.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/admin/reports/ReportGroup.scss">

<violation number="1" location="apps/antalmanac-planner/site/src/app/admin/reports/ReportGroup.scss:69">
P2: The subreport background uses an undefined CSS variable, so this declaration is ignored. Use the defined `--mui-palette-overlay-overlay3` token.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/search/CourseHitItem.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/search/CourseHitItem.tsx:45">
P2: Keyboard activation of this bookmark also triggers the enclosing course selection because the parent handles bubbled Enter/Space keydowns. Stop keydown propagation on the bookmark button so keyboard users can save without opening the preview.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/roadmap/toolbar/ImportZot4PlanPopup.scss">

<violation number="1" location="apps/antalmanac-planner/site/src/app/roadmap/toolbar/ImportZot4PlanPopup.scss:6">
P2: This selector does not match the warning icon's `import-schedule-icon` class, so its sizing and spacing styles never apply. Rename the selector to match the JSX class.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/roadmap/transfers/MenuSection.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/roadmap/transfers/MenuSection.tsx:25">
P2: The expand icon is a focusable button nested inside the header’s button-like `ClickableDiv`; its Enter/Space keydown toggles the section, then its native click bubbles and toggles it back. Use one interactive control for the header and render the chevron as decorative content.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/roadmap/sidebar/TabSelector.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/roadmap/sidebar/TabSelector.tsx:26">
P2: These buttons expose the selected choice only visually, so screen-reader users cannot tell which tab is active. Add `aria-pressed={isSelected}` to each button.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/component/ExpandMore/ExpandMore.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/component/ExpandMore/ExpandMore.tsx:11">
P2: Most usages render this icon-only button without an accessible name. Give it a default `aria-label` based on `expanded` (while allowing callers to override it).</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/roadmap/toolbar/Header.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/roadmap/toolbar/Header.tsx:62">
P2: The undo and redo icon-only buttons have no accessible names, so assistive technology announces them as unnamed buttons. Add `aria-label="Undo"` and `aria-label="Redo"` to the respective `IconButton`s.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/instructor/ProfessorPage.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/instructor/ProfessorPage.tsx:39">
P2: A rejected professor query leaves this page on the spinner indefinitely because `useProfessorData` does not expose or catch the rejection, and `error` is only ever cleared. Catch or expose the request error and render the error state.</violation>
</file>

<file name="apps/antalmanac-planner/api/drizzle/0029_planner_course_custom_card.sql">

<violation number="1" location="apps/antalmanac-planner/api/drizzle/0029_planner_course_custom_card.sql:3">
P2: This migration creates two mutually contradictory constraints on `planner_course.custom_card_id`: the FK with `ON DELETE set null` and the CHECK `(custom_card_id IS NOT NULL) = (course_id = 'CUSTOM')`. Deleting a `custom_card` that is referenced by a `course_id = 'CUSTOM'` row makes Postgres set `custom_card_id` to NULL, and PostgreSQL enforces constraints on referential-action updates ("these do not excuse you from observing any constraints"), so the DELETE fails with a check-constraint violation "is violated by some row". The app's `deleteCustomCard` (customCourses.ts) works around this by deleting the `planner_course` rows first, but any other deletion path breaks — notably `custom_card.user_id` is `ON DELETE cascade` (migration 0028), so deleting a user cascades into `custom_card` deletion and aborts with an error, and updating one of the orphaned rows later also re-evaluates and fails the CHECK. Use `ON DELETE cascade` on the FK (delete the placement with the card) or drop the CHECK, so the delete action cannot leave a row that violates the constraint.</violation>
</file>

<file name="apps/antalmanac-planner/api/drizzle/0004_sad_zzzax.sql">

<violation number="1" location="apps/antalmanac-planner/api/drizzle/0004_sad_zzzax.sql:3">
P2: This makes the default `now()` timestamp the only discriminator for imports of one schedule. Concurrent requests can share a microsecond timestamp, causing the second insert to violate this PK and fail `getScheduleFormatted`; existing duplicate pairs would also make this migration fail. Use a surrogate key and resolve any existing duplicates before adding the constraint.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/component/GradeDist/Chart.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/component/GradeDist/Chart.tsx:34">
P2: This component only renders a bar chart, so selecting the exposed `pie` option hides the chart entirely in minified grade distributions. Implement the pie variant or remove that option.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/roadmap/catalog/CustomCourseCard.scss">

<violation number="1" location="apps/antalmanac-planner/site/src/app/roadmap/catalog/CustomCourseCard.scss:14">
P2: The truncation rules target `.title`, but the description is rendered as `.description-body`, so long descriptions wrap and can spill beyond the fixed-height card. Apply these rules to `.description-body` instead.</violation>
</file>

<file name="apps/antalmanac-planner/infra/redirect-handler.mjs">

<violation number="1" location="apps/antalmanac-planner/infra/redirect-handler.mjs:7">
P2: This redirect also handles non-GET requests, but a 301 can turn POSTs into GETs and discard their bodies, breaking clients posting to legacy Planner APIs. Use 308 to preserve the method and body.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/search/ProfessorHitItem.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/search/ProfessorHitItem.tsx:24">
P2: Keyboard activation of a nested course link bubbles to `ClickableDiv`'s Enter/Space handler, which pushes the professor query instead. Stop the link's keydown from bubbling so it activates only the course preview.</violation>
</file>

<file name="apps/antalmanac-planner/api/src/helpers/platform.ts">

<violation number="1" location="apps/antalmanac-planner/api/src/helpers/platform.ts:19">
P2: Match the complete cookie pair instead of a substring; otherwise an unrelated cookie containing this text can send a web login through the native callback. Split the header on `;` and compare each trimmed pair exactly.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/roadmap/catalog/SavedCourses.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/roadmap/catalog/SavedCourses.tsx:42">
P2: This effect re-expands every department group whenever `savedCourses` changes, undoing a user's collapse after adding or removing a course. Expand only newly appearing groups instead of resetting all `saved-*` keys.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/roadmap/catalog/GERequiredCourseList.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/roadmap/catalog/GERequiredCourseList.tsx:41">
P2: If either query rejects, its success callback never resets the loading flag, leaving the CHC or GE pane on a spinner indefinitely. Handle failures and reset loading in a `finally` block.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/component/GradeDist/GradeDist.scss">

<violation number="1" location="apps/antalmanac-planner/site/src/component/GradeDist/GradeDist.scss:1">
P2: This unscoped rule also recolors Scheduler’s MUI card contents wherever GradeDist’s stylesheet is loaded. Scope it to `.gradedist-module-container` so the overlay applies only to GradeDist cards.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/roadmap/catalog/Library.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/roadmap/catalog/Library.tsx:73">
P2: `onStart` sets global drag state, but this source never clears it; add `onEnd` to reset it so quarter drop zones don't stay highlighted after release.</violation>
</file>

<file name="apps/antalmanac-planner/site/src/app/roadmap/catalog/MinorCourseList.tsx">

<violation number="1" location="apps/antalmanac-planner/site/src/app/roadmap/catalog/MinorCourseList.tsx:66">
P2: A successful empty result is treated as not-yet-loaded, so every response writes a new empty array and immediately triggers another request. Track fetch completion separately from the requirements length so an empty result does not create an endless API loop.</violation>
</file>

<file name="apps/antalmanac-planner/api/scripts/splitPlannerTables.ts">

<violation number="1" location="apps/antalmanac-planner/api/scripts/splitPlannerTables.ts:60">
P2: This stores legacy `CUSTOM#<id>` identifiers verbatim and leaves `custom_card_id` null. The current save path normalizes them to `course_id='CUSTOM'` plus the card ID; mirror that conversion so card lookup and deletion keep working.</violation>
</file>

<file name="apps/antalmanac-planner/api/src/next/session.ts">

<violation number="1" location="apps/antalmanac-planner/api/src/next/session.ts:33">
P2: A copied `planner_session` remains accepted indefinitely: cookie `Max-Age` only limits browser storage, while `deserializeSession` never checks an expiry. Put an expiry in the signed payload and reject it during deserialization.</violation>
</file>

<sub>Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

Re-trigger cubic</sub>

[Choollol]

Findings from a first pass:

App behavior

1. Auth seems to work, besides a planner hiccup described in a comment
2. Posthog network requests are sent on both sides
3. Navigating between apps work. There are some inconsistencies, but I think we can fix them after the merge
4. Features seem to work on both sides
5. Search with planner works

Not sure how to test aants or pwa

Also left some comments about setting up dev environment

I haven't looked at any code yet, will review again after I do

[Choollol]

Should we add a note about needing to have docker desktop/the engine background process open? Ran into this problem myself

[anthonyj33]

good idea will do

• Add note about docker desktop

[Choollol]

Should we add the BEGIN; ... COMMIT; fix mentioned by anthony? Rn the migrations fail

[anthonyj33]

yeah i will do

• Fix the migration issue

[Choollol]

Any idea why the profile pic is messed up on planner side?

Signing out doesn't work on planner either

[anthonyj33]

We made a recent change that means anyone who has logged into a staging recently will need to clear cookies

Won't affect users who have only been to prod and it will be fixed if you clear cookies

[Choollol]

On localhost, signing in on scheduler side then navigating to planner causes the app to crash if the planner-auth env variables, which are gotten from the planner team, aren't set. Don't know if we want to fix this before the merge, but definitely should be top priority after the merge

[anthonyj33]

PLANNER_SESSION_SECRET just needs to be set to a random string. Maybe we can add a note to the .env.example to indicate that

We could put a dummy string like "randomstringgoeshere" in .env.example because it doesn't really matter if it's secure for local dev. That way even if someone doesn't change it that can just act as the secret

[Choollol]

Notes for after the merge:

• The issue templates seem to mix up i.e. and e.g.
• Deduplicate route files
• Inconsistencies with planner app switcher (a vs. Link, no-op scheduler button on scheduler vs. planner link button on planner)

Will edit this comment if I add more

[Choollol]

(not related to the file, just commenting here so it's replyable)

Was there a particular reason the sub-folders have the "antalmanac-" prefix? Could we rename them to just "scheduler" and "planner"? Not a huge deal, but it would make things like project-specific searching in VSCode easier.

[anthonyj33]

planner link button on planner

This is because some pages on Planner use the Planner button as the only way to navigate "back" to the roadmap page (e.g. https://antalmanac.com/planner/instructor/thornton)

The reasoning for this, in short, is that if someone finds this page from a search engine, having a back arrow to go to the roadmap wouldn't actually be going back to where they came from. For the most part, these pages are typically used by people who a) used a search engine or b) had a link shared to them