Repository navigation
feat: human aircraft type names in notifications - #70
Merged
Merged
Conversation
Notifications printed bare designators (T38, BE20) because nothing carried
a readable name. Mictronics already ships one per row (long_type), which the
parser discarded. ADSBex `model` isn't a substitute: for FAA-registered
aircraft it is raw registry text ("200" for a King Air).
The name is kept as a per-designator table (~1.8k entries, most common
long_type per type) rather than a new key on each of ~600k hex entries.
The name only depends on the type, and growing every entry dict costs RSS
on a 2 GB Pi that the loader has already been OOM-killed on. Keying by type
also names aircraft missing from the per-hex DB, and rows whose own
long_type is blank.
Enrichment surfaces it as db_metadata.type_name — additive, optional.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolved in the blueprint's variables rather than the message so the message template, and its render tests, stay unchanged; the bare ICAO code remains the fallback when the DB has no name or databases are off. The dashboard example now prefers type_name over ADSBex `model` for the same reason the enricher does not use `model`: it reads "200" for FAA rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Patch, following the 1.1.7 precedent for additive enrichment: type_name is a new optional key inside db_metadata, so the payload contract and schema_version are untouched and no config changes are needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alert notifications printed bare ICAO designators (
T38,BE20). This adds a readable name.What
long_typecolumn as a per-designator table: the most common name for each type, ~1.8k entries (BE20→BEECH 200 Super King Air,T38→Northrop T-38C Talon).db_metadata.type_namefor any track whose designator has a name. The lookup is by type, so aircraft missing from the per-hex DB but broadcastingtget a name too.Why this shape
model. For FAA-registered aircraft it's raw registry text ("200"/"A200"for a King Air), so it can't name a type reliably.Notes
enable_databaseswith the Mictronics source.BEECH 200 Super King Air,AIRBUS A-320); no normalization.schema_versionis unchanged.Test plan
uv run pytest: 844 passeduv run mypy src,ruff check,ruff format --check🤖 Generated with Claude Code