chore: Use maps.Copy instead of manual copy loops - #19727
Open
SungJin1212 wants to merge 2 commits into
Open
SungJin1212 wants to merge 2 commits into
SungJin1212 wants to merge 2 commits into
Conversation
SungJin1212
force-pushed
the
modernize/mapsloop
branch
from
September 17, 2026 02:27
05abc80 to
f51e864
Compare
skartikey
approved these changes
Sep 17, 2026
skartikey
left a comment
skartikey
left a comment
Contributor
There was a problem hiding this comment.
@SungJin1212 Thanks for the contribution!
skartikey
added
the
ready for final review
SungJin1212
force-pushed
the
modernize/mapsloop
branch
from
September 18, 2026 02:17
f51e864 to
8dad7aa
Compare
srebhan
reviewed
Sep 18, 2026
srebhan
left a comment
srebhan
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution @SungJin1212! Some comments, mostly about using maps.Clone instead of allocating then copying.
Comment on lines
+206
to
+207
| j.Tags = make(map[string]string, len(o.Tags)) | ||
| for k, v := range o.Tags { | ||
| j.Tags[k] = v | ||
| } | ||
| maps.Copy(j.Tags, o.Tags) |
Member
There was a problem hiding this comment.
Wouldn't
Suggested change
| j.Tags = make(map[string]string, len(o.Tags)) | |
| for k, v := range o.Tags { | |
| j.Tags[k] = v | |
| } | |
| maps.Copy(j.Tags, o.Tags) | |
| j.Tags = maps.Clone(o.Tags) |
be even better? More occurrences below...
Comment on lines
+274
to
+275
| j.TagPassFilters = make(map[string][]string, len(o.TagPassFilters)) | ||
| for k, v := range o.TagPassFilters { | ||
| j.TagPassFilters[k] = v | ||
| } | ||
| maps.Copy(j.TagPassFilters, o.TagPassFilters) |
Member
There was a problem hiding this comment.
Clone, same for the other places below.
| tags[key] = val | ||
| } | ||
| maps.Copy(tags, headerTags) | ||
| maps.Copy(tags, fullPath.tags(h.TagPathPrefix)) |
Member
There was a problem hiding this comment.
Pre-allocation doesn't take this into account. Get the result of the function first and pre-allocate more precisely.
Comment on lines
+427
to
+428
| lastData = make(map[string]interface{}, len(data)) | ||
| for k, v := range data { | ||
| lastData[k] = v | ||
| } | ||
| maps.Copy(lastData, data) |
Comment on lines
+85
to
+86
| j.TagPassFilters = make(map[string][]string, len(o.TagPassFilters)) | ||
| for k, v := range o.TagPassFilters { | ||
| j.TagPassFilters[k] = v | ||
| } | ||
| maps.Copy(j.TagPassFilters, o.TagPassFilters) |
Comment on lines
147
to
+148
| t := make(map[string]string, len(tags)) | ||
| for k, v := range tags { | ||
| t[k] = v | ||
| } | ||
| maps.Copy(t, tags) |
Comment on lines
38
to
40
| m := make(map[string]string, len(s.tags)) | ||
| for k, v := range s.tags { | ||
| m[k] = v | ||
| } | ||
| maps.Copy(m, s.tags) | ||
| return m |
Member
There was a problem hiding this comment.
Clone.
Suggested change
| m := make(map[string]string, len(s.tags)) | |
| for k, v := range s.tags { | |
| m[k] = v | |
| } | |
| maps.Copy(m, s.tags) | |
| return m | |
| return maps.Clone(s.tags) |
Comment on lines
54
to
56
| m := make(map[string]string, len(s.tags)) | ||
| for k, v := range s.tags { | ||
| m[k] = v | ||
| } | ||
| maps.Copy(m, s.tags) | ||
| return m |
Comment on lines
113
to
+114
| tagsCopy := make(map[string]string, len(tags)) | ||
| for k, v := range tags { | ||
| tagsCopy[k] = v | ||
| } | ||
| maps.Copy(tagsCopy, tags) |
Comment on lines
116
to
+117
| fieldsCopy := make(map[string]any, len(fields)) | ||
| for k, v := range fields { | ||
| fieldsCopy[k] = v | ||
| } | ||
| maps.Copy(fieldsCopy, fields) |
Contributor
Author
|
@srebhan But |
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
modernize/mapsloop
branch
from
September 19, 2026 05:02
f0eff5f to
4ae4fce
Compare
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the modernize linter series (follow-up to #19675).
This PR replaces
for k, v := range src { dst[k] = v }loops withmaps.Copy(analyzer:mapsloop).The rewrite is the output of the modernize linter with only the listed analyzer(s) enabled, applied via
golangci-lint run --fixfor GOOS=darwin, linux and windows, followed bygoimports/golangci-lint fmtto drop imports left unused and regroup new ones.Checklist
Related issues
resolves #