Repository navigation
Remove leaf_index from CGKA add operation - #346
Merged
Merged
Conversation
expede
approved these changes
Nov 5, 2026
expede
left a comment
expede
left a comment
Member
There was a problem hiding this comment.
If only there was a programming language where a small conceptual change (remove unused field) was reflected in a small number LOC change :P Looks good!
jtfmumm
force-pushed
the
jtfm/remove-add-leaf-index
branch
from
November 5, 2026 08:19
51ce1d9 to
b0db6b8
Compare
jtfmumm
force-pushed
the
jtfm/remove-add-leaf-index
branch
from
November 5, 2026 08:30
b0db6b8 to
ec179c1
Compare
jtfmumm
force-pushed
the
jtfm/remove-add-leaf-index
branch
3 times, most recently
from
November 5, 2026 11:53
2f6ae1d to
ed3820b
Compare
Base automatically changed from
jtfm/node-versions-causal-past-removals
to
main
November 5, 2026 11:54
jtfmumm
force-pushed
the
jtfm/remove-add-leaf-index
branch
from
November 5, 2026 11:54
ed3820b to
267df30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't actually use the
leaf_indexfield on CGKA add operations and, under concurrency, it can be different from the leaf the updated member was actually at. This removes the field.Note that this breaks the wire format.