Repository navigation
fix(item-sliding): restore side switching - #31555
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
|
@minwookshin is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29975
What is the current behavior?
Opening the opposite side of an already-open item cancels the close timer but leaves
item-sliding-closingand a disabled swipe gesture behind. The newly opened options cannot be clicked, and the item cannot be swiped closed.What is the new behavior?
Cancelling that timer also removes the closing class and restores the gesture according to
disabled. Normal closing and closing another open item keep their existing behavior.Does this introduce a breaking change?
Other information
Added a manual reproduction at
core/src/components/item-sliding/test/open/index.htmland functional coverage for both switching directions, option clicks, swiping, disabled gestures, repeated switches, normal closing, and a second sliding item.Validation: 54 tests passed across Chromium, Firefox, and WebKit in iOS and MD modes; the click and swipe regressions both fail against the unchanged base. Core unit tests passed (87 suites, 803 tests), as did the existing functional sliding tests (8 passed, 1 existing WebKit skip), the core build, scoped ESLint, and formatting checks. These are functional tests, so no screenshot baselines changed.
Programmatic
open()in RTL still has the separate issue tracked as FW-3711 in the existing test helper. This PR follows that existing LTR restriction and does not claim to fix RTL.