Repository navigation
fix(palettes): align iOS dark list backgrounds - #31557
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
|
@minwookshin is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30146
What is the current behavior?
In the iOS dark palette, lists and items keep the page's black item background inside lighter cards and modals.
What is the new behavior?
Set the item background token to the card or modal background within those containers. The change is scoped to the iOS dark palette and preserves explicit item/list overrides, items outside cards, and light and MD palettes.
Does this introduce a breaking change?
Other information
Added a manual page and Linux screenshot coverage for default/custom cards, explicit item/list colors, default/custom modals, and cards nested in modals. Comparing against the unchanged palette produced exactly the nine intended iOS-dark differences; the other 27 screenshots were byte-for-byte unchanged. Inspected the changed surfaces and generated the baselines with the repository's Playwright 1.63.0 Docker image.
Validation: 36 new screenshot cases and six existing dark-modal cases pass across Chromium, Firefox, and WebKit, with one worker. The core build, 87 unit suites (803 tests), scoped stylelint/ESLint, and formatting checks also pass.