Repository navigation
feat(technology): place VMs on their virtualization platform - #255
Merged
Merged
Conversation
A vm TechnologyNode is servedBy the TechnologyService that hands out the VMs, which is suppliedBy the hypervisor, which is realizedBy its hosts. All relations already existed; this documents the chain and guards it: - lint warns about a vm with no platform (or no device it runs on) - lint reports a cycle that mixes the chain with composedOf/aggregates (a platform containing its own guest), which neither the relation nor the hierarchy cycle check saw; pure cycles stay reported once - example: guests on the regional cluster's compute service - kind descriptions and a Virtualization section in the modeling guide Closes #252 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #252
Summary
A VM node is placed on its platform through the service that hands out the VMs:
All three relations already exist, so no kind gets a new relation. The PR documents the chain and guards it in lint.
Linter::Structure#vm_without_platform): a vm node that is neitherservedBya service with asuppliedBy, norrealizedByaTechnologyDevice(a VM on one machine, e.g. the isolated session of a secure workstation already in the examples).validate_relation_cycles; now tested.validate_virtualization_cycles: a cycle that mixes the chain withcomposedOf/aggregates(a host cluster composed of a VM that runs on it). Neither existing check saw it, because each leaves out the other's verbs. It reusesrelation_graph/report_cycles(Tarjan) and only reports cycles that use both kinds of verb, so every cycle produces exactly one error.Tech:RegionalCluster:GuestsonTech:Compute:VirtualMachines→Tech:ClusterPlatform:Hypervisor→Tech:RegionalCluster:Host.Tech:RegionalCluster:Hypervisor(a cluster composed of hosts) was typedvmand is nowbare-metal.docs/modeling.md.Out of scope: an inverse "hosts" label on the platform page (incoming relations show the raw verb everywhere).
Test plan
archsight lint -r examples/archsight: no errors, no modeling warnings🤖 Generated with Claude Code