Repository navigation
Keep language callback output off the LSP protocol stream - #242
Merged
dannypsnl merged 1 commit intoSep 29, 2026
Merged
Conversation
Contain stdout during request dispatch and scheduled work while preserving the protocol writer and stderr. Exercise noisy reader, lexer and formatting callbacks through the server subprocess.
6cdh
approved these changes
Sep 29, 2026
dannypsnl
reviewed
Sep 29, 2026
dannypsnl
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A language reader, lexer or formatting hook that prints to stdout can interleave plain text with Content-Length frames and corrupt the LSP connection.
Discard callback stdout during request dispatch and scheduled work. The separate response writer retains the protocol output port, and stderr is preserved. Both scopes are needed because the scheduler thread exists before request dispatch establishes its output scope.
A server-subprocess regression exercises a noisy reader through initialization, document open and edit, semantic-token requests, diagnostics, formatting and shutdown. It requires exact protocol framing, useful token/formatting results, and preserved reader stderr. Negative controls fail on contaminated protocol headers when either output scope is removed.
Validation: 431 local tests passed on Racket 9.1 CS/Linux ARM64; formatting checked with fixw. Optional fmt, Resyntax, Nanopass and Pie integrations were unavailable locally and remain covered by CI.