Skip to content

feat(create): display wallet creation date and initial block height ( #638) - #1508

Merged
theborakompanioni merged 2 commits into
joinmarket-webui:develfrom
abhayrajjais01:feat/wallet-creation-date-display
Sep 29, 2026
Merged

theborakompanioni merged 2 commits into
joinmarket-webui:develfrom
abhayrajjais01:feat/wallet-creation-date-display

Conversation

@abhayrajjais01

Copy link
Copy Markdown
Contributor

What does this PR do?

Part 2 of #638 (following #1503).

When users create a wallet, they are prompted to write down their seed phrase and password. This PR adds the wallet's creation date (Month and Year, e.g. "April 2024") and starting block height (e.g. (Block #840,000)) on the wallet confirmation screen (CreateStepConfirm).

Recording this "Wallet Birthday" alongside the backup seed phrase allows users to easily recover their wallet later via the Month/Year datepicker introduced in #1503 without needing to rescan from genesis or look up exact block numbers.

Changes:

  • CreateStepConfirm: Added createdAt and blockHeight props with localized formatting ({ year: 'numeric', month: 'long' }) and instructional recovery caption.

  • CreateWalletPage: Passes the current creation timestamp and current session block height into the confirmation step.

  • i18n: Added localized keys (confirmation_label_wallet_birthday, confirmation_wallet_birthday_block, confirmation_description_wallet_birthday, confirmation_label_seedphrase).

  • Tests & Stories: Added unit tests covering default/custom birthday display, genesis block, and validation flow, along with a Storybook variant.

  • Fixes ui(import): Input custom rescan blockheight as year/month datepicker #638

Visual Demo

Image Demo:

Before After
Password & Seed Phrase only Birthday date & block number displayed with guidance caption
date_selection_june_2022_1790320125328

@theborakompanioni theborakompanioni added the enhancement New feature or request label Sep 28, 2026
@theborakompanioni theborakompanioni added this to the v2.1 milestone Sep 28, 2026
Comment thread src/i18n/locales/en/translation.json Resolved

@theborakompanioni theborakompanioni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some NITs, but would merge as is. You decide 🙏

@abhayrajjais01

Copy link
Copy Markdown
Contributor Author

Thanks for the review @theborakompanioni,

  1. Completely agree regarding avoiding a "magic" fallback to new Date(). I've updated CreateStepConfirm so the Wallet Birthday section is conditionally rendered only when createdAt is explicitly provided (createdAt?: Date), omitting it entirely when undefined. (In the app flow, CreateWalletPage always supplies createdAt: new Date())

  2. Applied your suggested wording for confirmation_description_wallet_birthday and updated the unit tests

@theborakompanioni theborakompanioni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 💪

@theborakompanioni
theborakompanioni merged commit 009992b into joinmarket-webui:devel Sep 29, 2026
2 checks passed
@abhayrajjais01
abhayrajjais01 deleted the feat/wallet-creation-date-display branch October 19, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui(import): Input custom rescan blockheight as year/month datepicker

2 participants