Repository navigation
fix(wallet): parse history timestamps without time zone as UTC - #1543
Open
CapThunder19 wants to merge 1 commit into
Open
CapThunder19 wants to merge 1 commit into
CapThunder19 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
JoinMarket NG writes
history.csvtimestamps without a timezone (e.g.2026-10-14T10:38:39.123456). The transaction history parsed them withnew Date(), which treats them as browser-local time. The Earn report treated them as UTC. So whenever the browser isn't on UTC, the same coinjoin showed different times on the two pages, off by the browser's UTC offset.This adds a small
parseHistoryTimestamphelper insrc/lib/that both views now use. It respects an explicit offset when one is present and treats everything else as UTC, which matches what the Earn report already did. If NG starts writing offsets later, this keeps working without changes.Tests run under non-UTC zones using the existing
withTimeZonehelper. The newTxHistoryTabletest fails ondeveland passes with this change.