Skip to content

fix(sweep): add missing i18n keys and replace hardcoded strings - #1546

Open
sh1vam31 wants to merge 6 commits into
joinmarket-webui:develfrom
sh1vam31:fix/1545-sweep-form-missing-i18n
Open

sh1vam31 wants to merge 6 commits into
joinmarket-webui:develfrom
sh1vam31:fix/1545-sweep-form-missing-i18n

Conversation

@sh1vam31

@sh1vam31 sh1vam31 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Fixes (Sweep: hardcoded English labels and descriptions in Scheduled Sweep form (missing i18n))#1545

This PR replaces hardcoded English labels, descriptions, action buttons, and validation messages in the Scheduled Sweep form with proper i18n translation keys.

Changes

  • i18n Keys: Added missing labels, descriptions, and validation feedback under the scheduler namespace in src/i18n/locales/en/translation.json.
  • SweepForm: Replaced raw strings for includeMakerSessions, min/maxNumberOfCollaborators, minNumberOfTransactionsPerJar, roundingChanceInPercent, and validation errors with t('scheduler...').
  • SweepDestinationInputs: Replaced hardcoded "Add additional destination" with t('scheduler.button_add_destination').
  • Testing: Added unit test coverage in SweepPage.test.tsx verifying that all scheduler option labels and descriptions render properly, and updated SweepDestinationInputs.test.tsx.

Steps to Reproduce

  1. Go to Settings (/settings) and switch the application language to Deutsch (German).
  2. Navigate to Sweep (/sweep) and open the Scheduled Sweep options dropdown ("Optionen für geplanten Sweep").
  3. Before: The options section header was translated, but all internal option labels, slider descriptions, and action buttons remained hardcoded in English.
  4. After: All labels, helper texts, and buttons are dynamically translated to German according to the active locale.

Note: The screenshots below compare the Scheduled Sweep options with the language set to German (Deutsch).

Before Fix After Fix
Before Fix After Fix

@sh1vam31

Copy link
Copy Markdown
Contributor Author

Hi @theborakompanioni ,

This PR is ready for review. It fixes #1545 by replacing hardcoded strings in the Scheduled Sweep form with proper i18n translation keys and adding unit tests.

Testing steps and before/after screenshots are included above.
Could you please take a look when you have a moment? Thanks.

@sh1vam31

Copy link
Copy Markdown
Contributor Author

Hi @theborakompanioni,
Kindly review this PR.

@theborakompanioni theborakompanioni added the i18n Issues related to translation and internationalisation (i18n) label Oct 18, 2026
@sh1vam31

Copy link
Copy Markdown
Contributor Author

Hi @theborakompanioni,
Kindly review this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Issues related to translation and internationalisation (i18n)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants