Repository navigation
Conversation
Contributor
Author
|
Hi @theborakompanioni , This PR is ready for review. It fixes #1545 by replacing hardcoded strings in the Scheduled Sweep form with proper Testing steps and before/after screenshots are included above. |
saurabhraghuvanshii
previously approved these changes
Oct 17, 2026
Contributor
Author
|
Hi @theborakompanioni, |
…into fix/1545-sweep-form-missing-i18n
Contributor
Author
|
Hi @theborakompanioni, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (Sweep: hardcoded English labels and descriptions in Scheduled Sweep form (missing i18n))#1545
This PR replaces hardcoded English labels, descriptions, action buttons, and validation messages in the Scheduled Sweep form with proper
i18ntranslation keys.Changes
schedulernamespace insrc/i18n/locales/en/translation.json.includeMakerSessions,min/maxNumberOfCollaborators,minNumberOfTransactionsPerJar,roundingChanceInPercent, and validation errors witht('scheduler...')."Add additional destination"witht('scheduler.button_add_destination').SweepPage.test.tsxverifying that all scheduler option labels and descriptions render properly, and updatedSweepDestinationInputs.test.tsx.Steps to Reproduce
/settings) and switch the application language to Deutsch (German)./sweep) and open the Scheduled Sweep options dropdown ("Optionen für geplanten Sweep").