Repository navigation
Refactor/ssh rs to russh - #104
Merged
r3dlight merged 5 commits intoMay 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
ssh-rswithrussh 0.60inkeysas-admin/src-tauri. The old crate has been unmaintained since 2024 (last commit, ~20 stale issues, no roadmap) and was the only blocker keeping the operator desktop on it.Strict drop-in: same algorithm set, same host-key behaviour, same
keysas/Changeme007defaults, same timeout, same SCP-over-exec upload (no SFTP). Public function names are preserved; call sites inlib.rsandutils.rsjust get.await. Error type unifies onanyhow::ResultsinceSshErrordisappears with the crate.Tested end-to-end against an OpenSSH 10 sshd:
connect_pwd,connect_key,session_exec, andsession_upload(with byte-exactsha256sumparity on the uploadedauthorized_keys).init_keysasagainst a real station still needs to be run before merge — I couldn't validate that path locally.A couple of pre-existing issues surfaced while testing, unrelated to the swap, worth a follow-up:
ManageView.vueandDisplaySigningConfig.vuepass{ type: 'info' | 'warning' }totauri-plugin-dialog'sconfirm(). Tauri 2 renamed that tokind:, so the dialogs silently no-op and the wrapped action never runs. Been broken since the Tauri v1→v2 upgrade.ssh-keygen -m PEM -t ed25519 -f mykey. OpenSSH 10 rejects that combination outright (invalid format). Still works on the stable-distro releases operators are actually on, but won't work on anything bleeding-edge.