fix: add missing TROUBLESHOOTING_URL and COMPATIBILITY_URL constants - #515
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds and exports two new configuration constants, TROUBLESHOOTING_URL and COMPATIBILITY_URL, pointing to game compatibility resources on GitHub. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
These were imported in menu.js but never defined in config.js, causing an uncaught exception on app start from openUrlMenuItem.
Fails on the #529 bug (TROUBLESHOOTING_URL/COMPATIBILITY_URL undefined at menu build) and guards the whole class: every key destructured from config/config in src/ must exist in config's exports, and *_URL exports must parse as URLs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lacymorrow
force-pushed
the
fix/missing-menu-urls
branch
from
August 25, 2026 20:21
eb1529d to
fa99b6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the v3.4.4 startup crash on all platforms (#529):
menu.jsdestructuresTROUBLESHOOTING_URLandCOMPATIBILITY_URLfromsrc/config/config.js, but they were never defined there.openUrlMenuItemthrows `The `url` option is required` at module load, crashing the main process before any window opens.Changes
TROUBLESHOOTING_URLandCOMPATIBILITY_URLconstants tosrc/config/config.jsand export them.test/config.spec.js): every key destructured fromconfig/configanywhere insrc/must exist in config's exports, and all exported*_URLvalues must parse as URLs. The test fails on the pre-fix tree and passes with the fix.Testing
playwright test test/config.spec.js— 2 passed with fix; verified the first test fails whenconfig.jsis reverted to the v3.4.4 version.eslintclean on the new test file.Paperclip: LAC-3424
🤖 Generated with Claude Code