chore(release): bump to 3.4.4 + fix release workflow (ship #486/#450 fixes) - #526
Merged
Merged
Conversation
…y run - version 3.4.2 -> 3.4.4: tags v3.4.2 and v3.4.3 already exist on origin (pre-workflow, neither contains the #486/#450 fixes); electron-builder requires the pushed tag to match package.json version - .nvmrc 18.18.2 -> 20.19.2: npm install fails on Node 18 with ERR_REQUIRE_ESM (sass@1.100.0 pulls chokidar@5, ESM-only, Node >=20) — same failure AppVeyor hit, fixed there in fdf6923 - release.yml: drop --ia32 from the Windows build — uiohook-napi ships no ia32 N-API prebuilt and npmRebuild is disabled (see af2097d) Prepares cutting v3.4.4 so the merged fixes for GH #486 (app stays open after quit) and #450 (--reset crash on Linux) finally ship (LAC-919). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares cutting v3.4.4 so the long-merged fixes for #486 (app stays open in background after quit) and #450 (
--resetcrash on Linux) finally ship in a release. Paperclip: LAC-919.Changes
v3.4.2andv3.4.3already exist on origin (both predate the release workflow and neither contains the fixes); electron-builder requires the pushed tag to match the package version.npm installfails on Node 18 withERR_REQUIRE_ESM(sass@1.100.0 → chokidar@5, ESM-only, Node ≥20). Same failure AppVeyor hit; fixed there in fdf6923. Without this the release workflow dies at install.--ia32from the Windows build — uiohook-napi ships no ia32 N-API prebuilt andnpmRebuildis disabled (see af2097d), so the ia32 package would ship a broken/missing native module.Release plan (after merge)
v3.4.4and push — triggers.github/workflows/release.yml(mac/win/linux/snap, publish to GitHub Releases).Testing notes
Config-only change (version + CI). Verification is the release workflow run itself; the Node-20 and x64-only decisions mirror fixes already proven on AppVeyor (fdf6923, af2097d).
🤖 Generated with Claude Code