Repository navigation
Feature/gravity free back sub - #649
Open
codyallard28 wants to merge 13 commits into
Open
codyallard28 wants to merge 13 commits into
codyallard28 wants to merge 13 commits into
Conversation
codyallard28
requested review from
JulianHammerl,
joaogvcarneiro,
patkenneally and
thibaudteil
November 2, 2026 20:11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gravity is left out of the back-substitution computations. Gravity is added at the very end of the equations of motion now. The hub solves for the non-gravitational acceleration, state effectors receive it as the
rDDotNonGrav_BN_Nargument ofcomputeDerivatives, and the spacecraft addsgonce to the hub velocity derivative. The accumulated delta-v now integrates only the non-gravitational acceleration, replacing the two gravity-velocity states with one.Interface changes:
StateEffector::updateContributionsno longer takesg_N.g_Ngravity property is removed.Commits: formatting first, then gravity leaves the effectors, then the delta-v rework, then docs. Each new test lands as a strict xfail and the commit that fixes it removes the xfail.
Verification
test_hinged_rigid_body_gravity_invariance: a hub and two hinged panels at rest in free fall stay exactly at rest.test_spacecraft_free_fall_delta_v: the accumulated delta-v comes only from the applied force, exactly.JitterFullyCoupledGravitytruth. (was not handling gravity properly before)Documentation
Model descriptions updated for spacecraft, hub, gravityEffector, dual hinged rigid bodies, linear spring-mass-damper, spherical pendulum and IMU. Spacecraft and gravityEffector carry the main change.
Future work
None