Repository navigation
perftest: change to not initialize ROCm GPU buffer - #411
Merged
Merged
Conversation
Co-authored-by: Vijay Sampath <Vijay.Sampath@amd.com> Signed-off-by: Pak Lui <pak.lui@amd.com>
Contributor
Author
|
hi @sshaulnv would you be able to review this PR for this 1-line change in the ROCm backend so it matches the other backends, thanks in advance! |
ahubbe-amd
approved these changes
Oct 12, 2026
Contributor
|
@paklui , thanks for the contribution, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ROCm memory backend reported
can_init = truefor buffers allocated withhipMalloc(). Whencan_init = trueis set, then ininitialize_buffer_content(), it would fill the GPU buffer with host CPU stores.The other accelerator memory backends use
can_init = falsefor device memory in their memory allocate buffer routine and leave the buffer content uninitialized, so we want to also be consistent and leave the buffer content uninitialized. To be consistent, this change setscan_init = falsein rocm_memory_allocate_buffer(), matching the other accelerator backends so to have the same behavior.This 1-liner change is limited to the ROCm memory backend. Verified with
--enable-rocm --enable-rocm_dmabufin build, and ran various perftests, likeib_write_bwandib_write_latwith--use_rocmand--use_rocm_dmabufbetween 2 nodes with AMD Instinct GPUs, runs complete, and bandwidth reaches line rate and latency unchanged.Please review and thanks in advance.