Repository navigation
Perftest: don't fail when mlx5dv_query_device() is unsupported - #413
Merged
Merged
Conversation
Treat a failed mlx5dv_query_device() as "no direct-verbs capabilities" instead of an error, in negotiate_params(), ctx_qp_create() and check_bf_support(). Its only nonzero return is EOPNOTSUPP from the dispatch wrapper, which means the provider is not mlx5. Also zero-initialize two mlx5dv_context structs that were passing a garbage request mask. No wire or ABI change. Signed-off-by: Shmuel Shaul <sshaul@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat a failed mlx5dv_query_device() as "no direct-verbs capabilities" instead of an error, in negotiate_params(), ctx_qp_create() and check_bf_support(). Its only nonzero return is EOPNOTSUPP from the dispatch wrapper, which means the provider is not mlx5. Also zero-initialize two mlx5dv_context structs that were passing a garbage request mask. No wire or ABI change.