Skip to content

nandpart: fix UAF when freeing mbr #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apritzel merged 1 commit into from
Nov 4, 2026
Merged

nandpart: fix UAF when freeing mbr #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion nand-part.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,13 +233,14 @@ static int writembrs(int fd, char names[][MAX_NAME], __u32 start, __u32 *lens, u
printf("\nready to write new partition tables:\n");
printmbr(mbr);
for (i = 0; i < MBR_COPY_NUM; i++) {
if (mbrs[i])
if (mbrs[i] && mbrs[i] != mbr)
_free_mbr(mbrs[i]);
}
printf("\nwrite new partition tables? (Y/N)\n");
read(0, &yn, 1);
if (yn != 'Y' && yn != 'y') {
printf("aborting\n");
_free_mbr(mbr);
return 0;
}

Expand All @@ -256,6 +257,7 @@ static int writembrs(int fd, char names[][MAX_NAME], __u32 start, __u32 *lens, u
perror("Failed rereading partition table");
#endif

_free_mbr(mbr);
return 1;
}

Expand Down
Loading