feat: add language update support to system service - #634
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds end-to-end language update support by exposing the network initialization component from SystemContainer and forwarding SystemService::UpdateLanguage locale changes to it. Sequence diagram for system language update propagationsequenceDiagram
participant Client
participant SystemService
participant SystemContainer
participant NetworkInitialization
Client->>SystemService: UpdateLanguage(locale)
SystemService->>SystemContainer: initializator()
SystemContainer-->>SystemService: NetworkInitialization*
SystemService->>NetworkInitialization: updateLanguage(locale)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
1. Add initializator() accessor method to SystemContainer class 2. Include networkinitialization.h header in systemservice.cpp 3. Implement UpdateLanguage slot in SystemService to handle locale updates 4. Declare UpdateLanguage slot in SystemService header 5. Enable language updates to be propagated through the system container to network initialization component Log: Added support for updating language settings in system service Influence: 1. Test UpdateLanguage method with various locale strings 2. Verify that language updates are properly propagated to network initialization 3. Test the initializator() accessor returns valid pointer 4. Verify system service handles language updates without crashes 5. Test integration with existing connectivity and IP conflict functionality 6. Verify no memory leaks or null pointer issues when updating language feat: 为系统服务添加语言更新支持 1. 在 SystemContainer 类中添加 initializator() 访问器方法 2. 在 systemservice.cpp 中包含 networkinitialization.h 头文件 3. 在 SystemService 中实现 UpdateLanguage 槽函数以处理区域设置更新 4. 在 SystemService 头文件中声明 UpdateLanguage 槽函数 5. 使语言更新能够通过系统容器传播到网络初始化组件 Log: 新增系统服务语言设置更新功能 Influence: 1. 使用不同的区域设置字符串测试 UpdateLanguage 方法 2. 验证语言更新是否正确传播到网络初始化组件 3. 测试 initializator() 访问器返回有效的指针 4. 验证系统服务处理语言更新时不会崩溃 5. 测试与现有连接性和 IP 冲突功能的集成 6. 验证更新语言时没有内存泄漏或空指针问题 PMS: TASK-395869
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 代码语法正确，逻辑清晰。m_network 在 SystemService 构造函数中已验证非空（构造函数中调用了 m_network->ipConfilctedChecker()），m_initializator 在 SystemContainer 构造函数中通过 new NetworkInitialization(this) 初始化保证非空。方法签名在 .h 和 .cpp 文件中一致。 2. 代码质量 ✅评价： 优秀 ✅ 通过 潜在问题：
建议： 建议为 UpdateLanguage 方法添加函数注释，说明 locale 参数的预期格式（如 zh_CN、en_US）及其功能。为 initializator() 添加简要注释说明返回值。OCR 审查建议：SystemContainer 中的原始指针成员（m_ipConflictHandler、m_connectivityHelper、m_initializator）可考虑使用 std::unique_ptr 或 QScopedPointer 管理，以遵循 RAII 原则，防止构造函数异常导致内存泄漏。 3. 代码性能 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 性能良好，资源使用合理。UpdateLanguage 方法仅进行简单的指针访问和方法调用，无性能开销。locale 参数使用 const QString& 传递，避免了不必要的拷贝。 4. 代码安全 🔒评价： 优秀 ✅ 通过
安全漏洞详情： 建议： 未发现安全漏洞。UpdateLanguage 作为 DBus 公开槽函数（Q_CLASSINFO D-Bus Interface），locale 参数来自外部 DBus 调用，建议在传入 NetworkInitialization::updateLanguage() 前进行基本格式校验（如限制为合法的 locale 字符串格式），增强防御性编程。下游 installLanguage() 使用 locale 构造翻译文件路径，虽然 QTranslator::load() 仅加载 .qm 格式文件限制了实际风险，但输入校验仍是良好实践。 💡 改进建议代码示例// 建议为 UpdateLanguage 添加注释和输入校验
/// \brief UpdateLanguage 更新系统网络服务的语言设置
/// \param locale 语言区域字符串，格式如 "zh_CN"、"en_US"
void SystemService::UpdateLanguage(const QString &locale)
{
// 基本格式校验，防止非法输入
if (locale.isEmpty() || locale.length() > 32) {
qCWarning(DSM) << "Invalid locale string:" << locale;
return;
}
m_network->initializator()->updateLanguage(locale);
}
// SystemContainer 建议使用智能指针管理（RAII）
// 头文件中：
// std::unique_ptr<SystemIPConflict> m_ipConflictHandler;
// std::unique_ptr<ConnectivityProcesser> m_connectivityHelper;
// std::unique_ptr<NetworkInitialization> m_initializator;本报告由 AI 代码审查工具自动生成 |
caixr23
approved these changes
Sep 21, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 52cyb, caixr23 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Added support for updating language settings in system service
Influence:
feat: 为系统服务添加语言更新支持
Log: 新增系统服务语言设置更新功能
Influence:
PMS: TASK-395869
Summary by Sourcery
Enable system services to update network language settings at runtime.
New Features:
Enhancements: