Repository navigation
fix(react): match the URL scheme case-insensitively in chat links - #1505
Merged
Merged
Conversation
RaphaelFakhri
requested review from
1egoman,
lukasIO and
thomasyuill-livekit
as code owners
November 4, 2026 01:16
|
@RaphaelFakhri is attempting to deploy a commit to the LiveKit Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: e1cb6c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasIO
approved these changes
Nov 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatChatMessageLinksaddshttps://to a URL unless it already starts withhttp://orhttps://. That check is case-sensitive, but the URL pattern that finds links is not. A message such asHttps://livekit.io, which mobile keyboards produce by capitalizing the first word, gets the linkhttps://Https://livekit.io, and the browser resolves it tohttps://https//livekit.io.This change makes the check case-insensitive. Other schemes still get the
https://prefix, as before, so a link never uses a scheme other thanhttporhttps.Changes
ChatEntry.tsx: match^https?://case-insensitively.ChatEntry.test.tsxcovering lowercase, mixed-case, uppercase, and scheme-less URLs.@livekit/components-react.Testing
pnpm exec vitest --run src/components/ChatEntry.test.tsxinpackages/react:Https://livekit.ioresolves tohttps://https//livekit.io).Fixes #1504