Skip to content

Coordinate MSVC toolsets and identify compiler-specific archives - #5

Open
PLPeeters wants to merge 1 commit into
lxml:masterfrom
PLPeeters:bugfix/win-builds
Open

PLPeeters wants to merge 1 commit into
lxml:masterfrom
PLPeeters:bugfix/win-builds

Conversation

@PLPeeters

Copy link
Copy Markdown

The Windows ARM64 builds started failing because iconv was built with a different MSVC version than lxml. With link-time optimization enabled, those compiler versions must match.

These changes select the MSVC toolset explicitly and include the exact compiler version in the archive names, so lxml can download matching libraries. It keeps link-time optimization enabled.

The corresponding lxml change needs a new binary release from this repository.

@scoder

scoder commented Nov 14, 2026

Copy link
Copy Markdown
Member

Thanks. Note that there is already lxml/lxml#539 which I'm considering to accept. Do you have an opinion on that?

@PLPeeters

Copy link
Copy Markdown
Author

Good old tunnel vision, completely missed that 😅

Having looked through it, I think that’s the better direction if we’re happy with requiring vcpkg for Windows source builds. It removes the separate binary-release dependency that my changes work around, so I’m happy to drop lxml/lxml#555 and this PR once it’s validated.

One thing I noticed: vcpkg.json needs to be included in the source distribution. I’d also want to see the ARM64 checks pass and verify a Windows build from the resulting sdist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants