Atorch DT20HBW: add Juwei CW24 product, fix remaining energy and warning, add counters - #6315
Open
doaelectronics-coder wants to merge 1 commit into
Open
doaelectronics-coder wants to merge 1 commit into
doaelectronics-coder wants to merge 1 commit into
Conversation
Atorch DT20HBW: add Juwei CW24 product, fix remaining energy and warning, add counters
doaelectronics-coder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds product id 6irqu0m73u9s3yfu (Juwei CW24, sold with Atorch branding), which currently only matches this config by DP fallback. Checked against my device's debug logs:
DP 123 is the battery's remaining energy and goes up and down, so total_increasing made HA treat every discharge as a meter reset. Changed to energy_storage / measurement, named "Remaining energy".
DP 133 also goes up and down and is remaining Ah (times voltage it tracks DP 123). Renamed "Total charge" to "Remaining capacity", class measurement.
DP 132 reports "off" when there is no fault; it was mapped to problem = on.
Added optional DPs my CW24 reports: 117/120 full/empty-charge voltage endpoints, 124 capacity mode, 126/127/128 charged/discharged/accumulated Ah, 129 accumulated kWh (all only increase).
The DP 123 and 133 renames change those entities' unique IDs for existing users. If you'd rather keep the DP 133 ID, I can restore the old name and keep only the class change.
yamllint and tests/test_device_config.py pass locally.