Skip to content

Do not raise on final job retry failure #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
oneiros wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Do not raise on final job retry failure #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/jobs/application_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ class ApplicationJob < ActiveJob::Base
retry_on ActiveRecord::Deadlocked

# Retry on HTTP errors
retry_on HTTPX::HTTPError, wait: HTTP_5XX_RETRY_DELAY
retry_on(HTTPX::HTTPError, wait: HTTP_5XX_RETRY_DELAY) do |job, error|
# Do not raise the error on the final retry
end

# Most jobs are safe to ignore if the underlying records are no longer available
discard_on ActiveJob::DeserializationError
Expand Down