Skip to content

Add the PHPStan configs the pre-push hook dispatches on [ignore_release] - #205

Merged
snake14 merged 1 commit into
6.x-devfrom
add-phpstan-hook-configs
Sep 24, 2026
Merged

snake14 merged 1 commit into
6.x-devfrom
add-phpstan-hook-configs

Conversation

@snake14

@snake14 snake14 commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Description

The plugin already ships the shared pre-push hook, and CI verifies it against the canonical copy, but the hook dispatches on phpstan/phpstan.created.neon and phpstan/phpstan.modified.neon and analyses nothing at all without them, so until now it has been a no-op here.

This adds both. Created files are held at level 9, since a new file carries no pre-existing debt; touched files inherit the plugin's level 5. Both include the plugin's existing phpstan.neon, and CI analyses only that file, so CI is unaffected.

Issue No

Related to PG-4897

Steps to Replicate the Issue

Not applicable — this adds tooling rather than fixing a defect.

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [NA] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✖] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [NA] Documentation updated?

Without phpstan/phpstan.created.neon and phpstan.modified.neon the hook runs, finds no config, and analyses nothing.
@snake14
snake14 marked this pull request as ready for review September 23, 2026 23:23
@snake14
snake14 requested a review from a team September 23, 2026 23:24
@snake14
snake14 enabled auto-merge (squash) September 23, 2026 23:24
@snake14
snake14 merged commit 22362f7 into 6.x-dev Sep 24, 2026
25 of 26 checks passed
@snake14
snake14 deleted the add-phpstan-hook-configs branch September 24, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants