Repository navigation
Bump js-yaml to 4.3.2 and markdown-it to 14.3.2 to fix CG security alerts - #9405
Merged
Sandeep Kumar Das (Sandeep-622) merged 1 commit intoOct 6, 2026
Merged
Sandeep Kumar Das (Sandeep-622) merged 1 commit into
Sandeep Kumar Das (Sandeep-622) merged 1 commit into
Conversation
Fixes Component Governance alerts in source/nodejs/package-lock.json: - js-yaml 4.1.0 -> 4.3.2: CVE-2026-59869, GHSA-5p4m-2wfm-xmqj, CVE-2026-84375 - linkify-it 5.0.0 -> 5.0.2 (via markdown-it 14.0.0 -> 14.3.2): CVE-2026-48801, CVE-2026-59887 mocha, lerna and nx pin js-yaml to exactly 4.1.0, so npm overrides force js-yaml 4.x to ^4.3.2. js-yaml 3.x copies are left unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f667f119-2039-4c2e-b107-b0a45ec5b4cf
Sandeep Kumar Das (Sandeep-622)
requested review from
a team,
Himanshi Goyal (himgoyalmicro) and
laxmikanth-msft
and
a balanced review from Copilot
October 5, 2026 07:21
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The manifests and lockfile consistently resolve the targeted vulnerable dependency versions, with appropriate verification reported.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Node.js dependencies to resolve Component Governance security alerts.
Changes:
- Upgrades
js-yaml, enforced through npm overrides. - Upgrades
markdown-it, resolvinglinkify-it5.0.2. - Refreshes the lockfile for updated transitive dependencies.
| File | Description |
|---|---|
source/nodejs/package.json |
Updates root dependencies and overrides. |
source/nodejs/package-lock.json |
Locks patched dependency versions. |
source/nodejs/adaptivecards-site/package.json |
Updates site development dependencies. |
source/nodejs/adaptivecards-react/package.json |
Updates the renderer’s markdown-it dependency. |
Files not reviewed (1)
- source/nodejs/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
laxmikanth-msft
approved these changes
Oct 5, 2026
Vineeth (vineethkuttan)
approved these changes
Oct 5, 2026
Sandeep Kumar Das (Sandeep-622)
deleted the
user/sandeepdas/fix-jsyaml-linkify-cves
branch
October 6, 2026 05:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes Component Governance security alerts on
AdaptiveCards-WinUi3-Renderer-Release(no GitHub issue): CVE-2026-59869, GHSA-5p4m-2wfm-xmqj, CVE-2026-84375 (js-yaml 4.1.0) and CVE-2026-48801, CVE-2026-59887 (linkify-it 5.0.0).Description
All five alerts come from
source/nodejs/package-lock.json.adaptivecards-sitedevDependencies now ask for^4.3.2.mocha,lernaandnxrequire exactly4.1.0, so this adds npmoverrides("js-yaml@4": "^4.3.2"plus a nestedmochaoverride) to force them onto the patched version. js-yaml 3.x copies are left unchanged.markdown-itfrom^14.0.0to^14.3.2(root,adaptivecards-react,adaptivecards-site). This is a minor version bump within 14.x.Lockfile changes are limited to js-yaml, markdown-it, linkify-it and uc.micro. Resolved URLs are
registry.npmjs.orgwith sha512 integrity, matching the existing entries.Sample Card
N/A (dependency update only).
How Verified
npm ls --package-lock-only --allreports no problems.npm cicompletes.lerna run buildsucceeds foradaptivecardsandadaptivecards-react(adaptivecards-reactbundles markdown-it).@microsoft/ac-typed-schemabuild-and-test passes (28 tests).@microsoft/marked-schematest passes.adaptivecardsjest: 24 of 25 suites pass.carousel.spec.tsfails to compile (TS2554: two calls pass 5 arguments where 4 are expected). That file is unrelated to these packages; I did not re-run it on main.