Add independent VS Code extension releases - #64139
Open
Jake Bailey (jakebailey) wants to merge 24 commits into
Open
Add independent VS Code extension releases#64139Jake Bailey (jakebailey) wants to merge 24 commits into
Jake Bailey (jakebailey) wants to merge 24 commits into
Conversation
Validate the package-lock version before creating a release tag and remove the unsupported test-signing path from the VSIX build pipeline.
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
September 3, 2026 18:28
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The bump workflow must branch from main and create the documented pull request.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds independent versioning, tagging, building, signing, and publishing for the VS Code TypeScript extension.
Changes:
- Adds version-bump and release-tag workflows.
- Adds dedicated Azure build and publish pipelines.
- Extends packaging with independent versions and release manifests.
File summaries
| File | Description |
|---|---|
tools/pipelines/vscode-typescript-publish.yml |
Validates and publishes release artifacts. |
tools/pipelines/vscode-typescript-build.yml |
Builds and signs tagged VSIX artifacts. |
Herebyfile.mjs |
Implements extension release packaging and manifests. |
.github/workflows/tag-vscode-typescript.yml |
Creates reviewed release tags. |
.github/workflows/bump-vscode-typescript.yml |
Prepares version-bump release branches. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
September 4, 2026 20:23
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The release supply chain is not lockfile-pinned, and release-mode CI coverage and PR-trigger safeguards are missing.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 10/11 changed files
- Comments generated: 3
- Review effort level: Balanced
Fetch native package tarballs using the lockfile URLs and verify their\nSHA-512 integrity before packaging. Exercise the extension release path in\nCI and explicitly disable pull request triggers for the publish pipeline.
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
September 4, 2026 21:27
View session
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Release asset consistency remains unresolved, and the publishing workflow requires final human review.
Review details
Suppressed comments (1)
tools/pipelines/vscode-typescript-publish.yml:246
- This note attributes the bundled compiler to the extension release commit, but the compiler is downloaded from the pinned
@typescript/bundled-typescriptnpm package and may have been built from a different commit. Label this SHA as the extension source commit so the release metadata does not imply incorrect compiler provenance.
--notes "Bundles TypeScript $bundledTypeScriptVersion from commit $sourceCommit."
- Files reviewed: 10/11 changed files
- Comments generated: 1
- Review effort level: Balanced
Jake Bailey (jakebailey)
marked this pull request as ready for review
September 4, 2026 22:42
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
September 4, 2026 22:45
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Tag validation must reject leading-zero SemVer components before creating permanent release tags.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 10/11 changed files
- Comments generated: 1
- Review effort level: Balanced
| exit 0 | ||
| fi | ||
|
|
||
| if ! [[ "$version" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the release workflow for our VS Code extension.
The release procedure is:
vscode-typescript/v1.2.3Perhaps a bit roundabout, and requires two manual steps, but we could not require a second approval to actually get the bits out.
I expect to do something somewhat similar for the main TS releases, which have to operate in a very similar way.
Fixes #63924