Repository navigation
[4/9] Add five Account Overview configuration and request advisories - #3569
Conversation
Integration Tests
|
✅ Build (Compile, Lint, Prettier, l10n, Package)🧱 Step Results
📥 Artifacts (run) |
🎭 E2E Tests (Playwright + VS Code)🧪 Result
|
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/vitest
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
🧪 Unit Tests🧪 Results
📈 Coverage |
af55161 to
97eec69
Compare
97eec69 to
8a0b455
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Inventory acquisition failures incorrectly mark reserved-capacity review as unavailable for Serverless accounts, even though reservations do not apply and the detector skips them.
1 open issue
What changed in this PR
This PR extends Account Overview with five configuration and request advisories, building on the preceding request-log work without introducing financial estimates.
Changes:
- Adds paid continuous-backup, non-throttling error, throttled-operation, per-region autoscale, and reserved-capacity reviews.
- Shares a seven-day status observation between request rules and fetches operation details only after volume and rate thresholds pass.
- Integrates coverage reporting, registry entries, UI descriptions, localization, documentation, and regression tests.
| File | Description |
|---|---|
src/webviews/cosmosdb/AccountOverview/DerivedAdvisories.tsx |
Adds names and descriptions for five rules. |
src/webviews/cosmosdb/AccountOverview/DerivedAdvisories.test.tsx |
Tests accessible rendering and keyboard-opened details. |
src/panels/trpc/routers/accountOverview/derivedAdvisoriesRouter.ts |
Preserves configuration coverage when Monitor is unavailable. |
src/panels/trpc/routers/accountOverview/derivedAdvisoriesRouter.test.ts |
Tests configuration inputs and acquisition fallbacks. |
src/panels/accountOverview/services/advisories/registry.ts |
Registers the five detectors. |
src/panels/accountOverview/services/advisories/missingDetectors.test.ts |
Tests thresholds, classifications, and rule integration. |
src/panels/accountOverview/services/advisories/index.ts |
Exports the new detectors. |
src/panels/accountOverview/services/advisories/fetchers/metrics.ts |
Fetches account status and throttled-operation counts. |
src/panels/accountOverview/services/advisories/fetchers/accountRequests.test.ts |
Tests metric queries, parsing, and failure handling. |
src/panels/accountOverview/services/advisories/detectors/ThrottlingByOperationDetector.ts |
Identifies dominant throttled operations. |
src/panels/accountOverview/services/advisories/detectors/ReservedCapacityCandidateDetector.ts |
Adds provisioned-capacity reservation review. |
src/panels/accountOverview/services/advisories/detectors/PerRegionAutoscaleCandidateDetector.ts |
Adds independent-autoscale configuration review. |
src/panels/accountOverview/services/advisories/detectors/PaidContinuousBackupDetector.ts |
Reviews paid retention on inferred non-production accounts. |
src/panels/accountOverview/services/advisories/detectors/NonThrottlingErrorsDetector.ts |
Evaluates non-429 errors with conditional guidance. |
src/panels/accountOverview/services/advisories/core/types.ts |
Defines new rules, inputs, and evaluation results. |
src/panels/accountOverview/services/advisories/core/thresholds.ts |
Adds request and reservation thresholds. |
src/panels/accountOverview/services/advisories/core/requestMetrics.ts |
Summarizes statuses and classifies operations. |
src/panels/accountOverview/services/advisories/core/helpers.ts |
Classifies configuration and missing inputs. |
src/panels/accountOverview/services/advisories/collectParity.test.ts |
Tests shared collection, gating, and incomplete inventory. |
src/panels/accountOverview/services/advisories/collect.ts |
Wires request evidence and reservation coverage. |
specs/account-overview.md |
Documents thresholds, evidence, and advisory limits. |
l10n/bundle.l10n.json |
Adds source strings for the new advisories. |
Review effort: Balanced
8a0b455 to
3e75780
Compare
3e75780 to
2d07b81
Compare
2d07b81 to
7d3e185
Compare
4c1b563 to
d57307c
Compare
d57307c to
2c97db3
Compare
2c97db3 to
3952c4e
Compare
3952c4e to
5a9bd51
Compare
Register five additional native rules, share one seven-day status observation across account request checks, and keep unavailable configuration or operation evidence distinct from a clean result. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep reservation coverage in the existing provisioned-only capacity check instead of the unconditional inventory-failure list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5a9bd51 to
e20b4b4
Compare

Summary
Add paid continuous-backup retention review, non-throttling errors, throttling by operation, per-region autoscale review and reserved-capacity review.
One seven-day account status observation feeds both request rules; the operation breakdown runs only after its volume/rate gates pass. Missing configuration and incomplete inventory remain distinct from clean results. Includes registry/router/UI integration, regressions and localization; no financial estimates are introduced here.
Stack
Part 4 of 9 in the Account Overview advisory stack. Depends on #3568. Base: dev/dshilov/account-overview-03-request-logs.
Each subsequent PR targets its predecessor branch so GitHub can represent the chain as a native PR stack.
Validation
The integrated stack passed localization generation, oxfmt, lint, all TypeScript build targets, and all unit suites. The full unit command used VITEST_MAX_WORKERS=2 to avoid local resource-contention timeouts. Intermediate runtime branches also passed builds and focused regressions.
Review fixes are committed to their originating PR layers; descendants are rebased onto the updated predecessors.