Skip to content

[4/9] Add five Account Overview configuration and request advisories - #3569

Open
Dmitrii Shilov (bk201-) wants to merge 3 commits into
dev/dshilov/account-overview-03-request-logsfrom
dev/dshilov/account-overview-04-additional-advisories
Open

Dmitrii Shilov (bk201-) wants to merge 3 commits into
dev/dshilov/account-overview-03-request-logsfrom
dev/dshilov/account-overview-04-additional-advisories

Conversation

@bk201-

@bk201- Dmitrii Shilov (bk201-) commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add paid continuous-backup retention review, non-throttling errors, throttling by operation, per-region autoscale review and reserved-capacity review.

One seven-day account status observation feeds both request rules; the operation breakdown runs only after its volume/rate gates pass. Missing configuration and incomplete inventory remain distinct from clean results. Includes registry/router/UI integration, regressions and localization; no financial estimates are introduced here.

Stack

Part 4 of 9 in the Account Overview advisory stack. Depends on #3568. Base: dev/dshilov/account-overview-03-request-logs.
Each subsequent PR targets its predecessor branch so GitHub can represent the chain as a native PR stack.

Validation

The integrated stack passed localization generation, oxfmt, lint, all TypeScript build targets, and all unit suites. The full unit command used VITEST_MAX_WORKERS=2 to avoid local resource-contention timeouts. Intermediate runtime branches also passed builds and focused regressions.
Review fixes are committed to their originating PR layers; descendants are rebased onto the updated predecessors.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Integration Tests

  • Shell MCP Integration Tests: ✅ success
  • Integration Tests (extension host): ✅ success

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

✅ Build (Compile, Lint, Prettier, l10n, Package)

🧱 Step Results

  • Validate Version: ✅ success
  • Localization: ✅ success
  • Lint: ✅ success
  • Prettier: ✅ success
  • Compile (tsc): ✅ success
  • Package: ✅ success
  • External Skills: verification ✅ success; tests ✅ success

📥 Artifacts (run)

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

🎭 E2E Tests (Playwright + VS Code)

🧪 Result

  • E2E Tests: ✅ success

⚠️ Flaky tests (1)

These tests passed only after retrying. The test run is still successful unless other tests failed.

  • data-modeler-radio-cards.spec.ts › Selected workload radios keep their color on hover and show focus only on the card — data-modeler-radio-cards.spec.ts:9 (default, 2 attempts)

📥 Artifacts (run)

Tip: the HTML report artifact contains a self-contained Playwright report.
Download the zip, extract, and open index.html — or run
npx playwright show-report <extracted-dir> for the interactive view.

@github-code-quality

github-code-quality Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage/vitest

dev/dshilov/account-... 5c8102d dev/dshilov/account-... e20b4b4 +/-
77% 78% +1%
View coverage of the 10 most impacted files.
File dev/dshilov/account-... 5c8102d dev/dshilov/account-... e20b4b4 +/-
src/panels/acco...etchers/logs.ts 100% 98% -2%
src/panels/acco...ries/collect.ts 92% 96% +4%
src/cosmosdb/Az...urceMetadata.ts 15% 50% +35%
src/panels/acco...rorsDetector.ts 0% 96% +96%
src/panels/acco...tionDetector.ts 0% 100% +100%
src/panels/acco...questMetrics.ts 0% 100% +100%
src/panels/acco...ctors/fanout.ts 0% 100% +100%
src/panels/acco...dateDetector.ts 0% 100% +100%
src/panels/acco...ckupDetector.ts 0% 100% +100%
src/panels/acco...dateDetector.ts 0% 100% +100%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 19, 2026 17:31 UTC

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

🧪 Unit Tests

🧪 Results

  • Unit Tests (vitest): ✅ success

📈 Coverage

@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-04-additional-advisories branch from af55161 to 97eec69 Compare November 11, 2026 18:57
@bk201- Dmitrii Shilov (bk201-) changed the title [4/7] Add five Account Overview configuration and request advisories [4/8] Add five Account Overview configuration and request advisories Nov 12, 2026
Copilot AI balanced review requested due to automatic review settings November 13, 2026 11:09
@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-04-additional-advisories branch from 97eec69 to 8a0b455 Compare November 13, 2026 11:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Inventory acquisition failures incorrectly mark reserved-capacity review as unavailable for Serverless accounts, even though reservations do not apply and the detector skips them.

1 open issue
What changed in this PR

This PR extends Account Overview with five configuration and request advisories, building on the preceding request-log work without introducing financial estimates.

Changes:

  • Adds paid continuous-backup, non-throttling error, throttled-operation, per-region autoscale, and reserved-capacity reviews.
  • Shares a seven-day status observation between request rules and fetches operation details only after volume and rate thresholds pass.
  • Integrates coverage reporting, registry entries, UI descriptions, localization, documentation, and regression tests.
File Description
src/​webviews/​cosmosdb/​AccountOverview/​DerivedAdvisories.tsx Adds names and descriptions for five rules.
src/​webviews/​cosmosdb/​AccountOverview/​DerivedAdvisories.test.tsx Tests accessible rendering and keyboard-opened details.
src/​panels/​trpc/​routers/​accountOverview/​derivedAdvisoriesRouter.ts Preserves configuration coverage when Monitor is unavailable.
src/​panels/​trpc/​routers/​accountOverview/​derivedAdvisoriesRouter.test.ts Tests configuration inputs and acquisition fallbacks.
src/​panels/​accountOverview/​services/​advisories/​registry.ts Registers the five detectors.
src/​panels/​accountOverview/​services/​advisories/​missingDetectors.test.ts Tests thresholds, classifications, and rule integration.
src/​panels/​accountOverview/​services/​advisories/​index.ts Exports the new detectors.
src/​panels/​accountOverview/​services/​advisories/​fetchers/​metrics.ts Fetches account status and throttled-operation counts.
src/​panels/​accountOverview/​services/​advisories/​fetchers/​accountRequests.test.ts Tests metric queries, parsing, and failure handling.
src/​panels/​accountOverview/​services/​advisories/​detectors/​ThrottlingByOperationDetector.ts Identifies dominant throttled operations.
src/​panels/​accountOverview/​services/​advisories/​detectors/​ReservedCapacityCandidateDetector.ts Adds provisioned-capacity reservation review.
src/​panels/​accountOverview/​services/​advisories/​detectors/​PerRegionAutoscaleCandidateDetector.ts Adds independent-autoscale configuration review.
src/​panels/​accountOverview/​services/​advisories/​detectors/​PaidContinuousBackupDetector.ts Reviews paid retention on inferred non-production accounts.
src/​panels/​accountOverview/​services/​advisories/​detectors/​NonThrottlingErrorsDetector.ts Evaluates non-429 errors with conditional guidance.
src/​panels/​accountOverview/​services/​advisories/​core/​types.ts Defines new rules, inputs, and evaluation results.
src/​panels/​accountOverview/​services/​advisories/​core/​thresholds.ts Adds request and reservation thresholds.
src/​panels/​accountOverview/​services/​advisories/​core/​requestMetrics.ts Summarizes statuses and classifies operations.
src/​panels/​accountOverview/​services/​advisories/​core/​helpers.ts Classifies configuration and missing inputs.
src/​panels/​accountOverview/​services/​advisories/​collectParity.test.ts Tests shared collection, gating, and incomplete inventory.
src/​panels/​accountOverview/​services/​advisories/​collect.ts Wires request evidence and reservation coverage.
specs/​account-overview.md Documents thresholds, evidence, and advisory limits.
l10n/​bundle.l10n.json Adds source strings for the new advisories.

Review effort: Balanced

@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-04-additional-advisories branch from 8a0b455 to 3e75780 Compare November 13, 2026 12:22
Copilot AI balanced review requested due to automatic review settings November 13, 2026 12:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Inventory failures incorrectly trigger a reserved-capacity access warning for Serverless accounts, even though that review is inapplicable to them.

1 open issue

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 13, 2026 13:33
@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-04-additional-advisories branch from 3e75780 to 2d07b81 Compare November 13, 2026 13:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the five new Account Overview advisories.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-04-additional-advisories branch from 2d07b81 to 7d3e185 Compare November 13, 2026 13:59
Copilot AI balanced review requested due to automatic review settings November 13, 2026 13:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the five new Account Overview advisories.

No open issues 🎉

Review effort: Balanced

@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-04-additional-advisories branch from 4c1b563 to d57307c Compare November 13, 2026 15:42
Copilot AI balanced review requested due to automatic review settings November 13, 2026 15:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the configuration and request advisory additions.

No open issues 🎉

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues require changes to the five new configuration and request advisories.

No open issues 🎉

Review effort: Balanced

@bk201- Dmitrii Shilov (bk201-) changed the title [4/8] Add five Account Overview configuration and request advisories [4/9] Add five Account Overview configuration and request advisories Nov 18, 2026
@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-04-additional-advisories branch from 2c97db3 to 3952c4e Compare November 19, 2026 11:55
Copilot AI balanced review requested due to automatic review settings November 19, 2026 11:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain that require changes.

No open issues 🎉

Review effort: Balanced

@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-04-additional-advisories branch from 3952c4e to 5a9bd51 Compare November 19, 2026 12:47
Copilot AI balanced review requested due to automatic review settings November 19, 2026 12:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the five new account-wide advisories.

No open issues 🎉

Review effort: Balanced

Register five additional native rules, share one seven-day status observation across account request checks, and keep unavailable configuration or operation evidence distinct from a clean result.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep reservation coverage in the existing provisioned-only capacity check instead of the unconditional inventory-failure list.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-04-additional-advisories branch from 5a9bd51 to e20b4b4 Compare November 19, 2026 17:24
Copilot AI balanced review requested due to automatic review settings November 19, 2026 17:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the addition of the five account-wide advisories.

No open issues 🎉

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants