Skip to content

[7/9] Add an independent CODA freshness advisory check - #3572

Open
Dmitrii Shilov (bk201-) wants to merge 12 commits into
dev/dshilov/account-overview-06-coda-conformancefrom
dev/dshilov/account-overview-07-coda-freshness
Open

Dmitrii Shilov (bk201-) wants to merge 12 commits into
dev/dshilov/account-overview-06-coda-conformancefrom
dev/dshilov/account-overview-07-coda-freshness

Conversation

@bk201-

@bk201- Dmitrii Shilov (bk201-) commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Compare the configured CODA branch HEAD with the immutable pin without repinning or executing upstream code. Report exact ahead/behind counts and distinguish rewound, divergent, unrelated and unverifiable histories.

The package-feed workflow gains an independent optional freshness job. Hosted execution is temporarily paused for all triggers with if: ${{ false }} until server-side verification and private-source access are needed. The job is skipped, not reported as current. Local npm run coda:check, token support and the existing isolation of private credentials from all pull requests remain unchanged. Includes synthetic local-Git tests and contributor documentation. Required-check settings are unchanged.

Stack

Part 7 of 9 in the Account Overview advisory stack. Depends on #3571. Base: dev/dshilov/account-overview-06-coda-conformance.
Each subsequent PR targets its predecessor branch so GitHub can represent the chain as a native PR stack.

Validation

The temporary-pause follow-up passed oxfmt, full lint, all TypeScript build targets and all unit suites, using VITEST_MAX_WORKERS=2. A workflow regression test verifies the explicit pause and retained credential isolation. No user-facing strings changed.
The original worktree remains preserved in the local snapshot; this follow-up intentionally pauses only hosted CODA execution.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

✅ Build (Compile, Lint, Prettier, l10n, Package)

🧱 Step Results

  • Validate Version: ✅ success
  • Localization: ✅ success
  • Lint: ✅ success
  • Prettier: ✅ success
  • Compile (tsc): ✅ success
  • Package: ✅ success
  • External Skills: verification ✅ success; tests ✅ success

📥 Artifacts (run)

None

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Integration Tests

  • Shell MCP Integration Tests: ✅ success
  • Integration Tests (extension host): ✅ success

@github-code-quality

github-code-quality Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage/vitest

dev/dshilov/account-... 5c8102d dev/dshilov/account-... 9002d2a +/-
77% 78% +1%
View coverage of the 10 most impacted files.
File dev/dshilov/account-... 5c8102d dev/dshilov/account-... 9002d2a +/-
src/panels/acco...onalFixtures.ts 0% 67% +67%
src/panels/acco...nce/bindings.ts 0% 73% +73%
src/panels/acco...onalBindings.ts 0% 86% +86%
src/panels/acco...nce/features.ts 0% 93% +93%
src/panels/acco...mance/shared.ts 0% 95% +95%
src/panels/acco...rorsDetector.ts 0% 96% +96%
src/panels/acco...s/backupCost.ts 0% 97% +97%
src/panels/acco...stManagement.ts 0% 99% +99%
src/panels/acco...ostEstimates.ts 0% 100% +100%
src/panels/acco...tionDetector.ts 0% 100% +100%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 19, 2026 17:31 UTC

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

🧪 Unit Tests

🧪 Results

  • Unit Tests (vitest): ✅ success

📈 Coverage

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

🎭 E2E Tests (Playwright + VS Code)

🧪 Result

  • E2E Tests: ✅ success

📥 Artifacts (run)

Tip: the HTML report artifact contains a self-contained Playwright report.
Download the zip, extract, and open index.html — or run
npx playwright show-report <extracted-dir> for the interactive view.

@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-07-coda-freshness branch from ecca3ec to b4fd81e Compare November 11, 2026 18:57
Copilot AI balanced review requested due to automatic review settings November 12, 2026 11:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the read-only CODA freshness check.

No open issues 🎉

What changed in this PR

Adds a read-only freshness check alongside the pinned CODA conformance tooling, comparing the configured branch HEAD with the immutable pin without repinning or executing upstream code.

Changes:

  • Reports exact ahead/behind counts and distinguishes equal, rewound, divergent, unrelated, and unverifiable histories.
  • Adds an independent optional advisory job, currently disabled for all hosted triggers, with private credentials withheld from every pull request.
  • Adds synthetic local-Git tests and contributor documentation for local usage and hosted behavior.
File Description
scripts/​check-coda-freshness.test.mjs Tests history relationships, failure handling, cleanup, credential handling, and workflow safeguards.
scripts/​check-coda-freshness.mjs Implements read-only comparison, reporting, and exit statuses using a disposable bare repository.
package.json Adds coda:check and includes freshness tests in the CODA tooling suite.
CONTRIBUTING.md Documents freshness results, local usage, and the hosted pause and credential restrictions.
.github/​workflows/​package-feed.yml Renames the workflow and adds the paused, independent CODA freshness job.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 12, 2026 17:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Recently deleted containers can consume limited slots in the 24-hour wildcard query, making backup estimates unavailable even when all current containers have fresh measurements.

1 open issue

Review effort: Balanced

@bk201- Dmitrii Shilov (bk201-) changed the title [7/7] Add an independent CODA freshness advisory check [7/8] Add an independent CODA freshness advisory check Nov 12, 2026
@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-07-coda-freshness branch from 784ced4 to 5d996f2 Compare November 13, 2026 11:09
Copilot AI balanced review requested due to automatic review settings November 13, 2026 11:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Grouped cost requests run serially rather than in bounded batches, potentially delaying advisory loading substantially across many databases.

1 open issue
1 resolved since last review

Review effort: Balanced

@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-07-coda-freshness branch from 5d996f2 to 3a84a66 Compare November 13, 2026 12:22
Copilot AI balanced review requested due to automatic review settings November 13, 2026 12:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Optional cost enrichment lacks an overall cancellable deadline, so long server-directed retry delays can block the entire advisory response instead of returning unavailable cost coverage.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread src/utils/azureClients.ts Resolved
@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-07-coda-freshness branch from 3a84a66 to 70c1867 Compare November 13, 2026 13:33
Copilot AI balanced review requested due to automatic review settings November 13, 2026 13:33
@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-07-coda-freshness branch from dd5cacb to 02c84de Compare November 13, 2026 19:42
Copilot AI balanced review requested due to automatic review settings November 13, 2026 19:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the CODA freshness and Account Overview changes.

No open issues 🎉

Review effort: Balanced

@bk201- Dmitrii Shilov (bk201-) changed the title [7/8] Add an independent CODA freshness advisory check [7/9] Add an independent CODA freshness advisory check Nov 18, 2026
Copilot AI balanced review requested due to automatic review settings November 19, 2026 11:55
@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-07-coda-freshness branch from 02c84de to 9c0eff1 Compare November 19, 2026 11:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the read-only freshness tooling and related collection safeguards.

No open issues 🎉

Review effort: Balanced

@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-07-coda-freshness branch from 9c0eff1 to 9666dd4 Compare November 19, 2026 12:48
Compare the upstream branch and immutable pin with exact history relationships, retain explicit failures, and withhold private-source credentials from all pull-request runs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the local checker and authentication intact while server-side private-source verification is not needed. Mark the independent hosted job skipped for all triggers and document the pause with regression coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Batch backup storage metrics and skip dependent queries for empty log sources while preserving independent checks. Handle Kusto empty-write aggregates and case-folded Monitor dimensions.

Normalize Cost Management retry-after headers for the existing SDK retry policy, preserving its attempt limits and cancellation. Add regression coverage and update the overview specification.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Historical deleted-container series could consume the wildcard query limit and hide fresh storage evidence for current containers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Database-grouped requests were awaited serially, multiplying storage collection latency. Restore waves of five reads while retaining per-request identity and cross-wave snapshot checks, and stop later waves and pricing on failure.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bound ARM retry waits, Monitor reads and retail pagination together without retrying before the server allows it; retain qualitative findings and categorized timeout coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Check the shared deadline before backup preconditions and ensure an hours-long retry never postpones qualitative findings.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document the intentionally disabled hosted job while retaining the local freshness command.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
An early failed storage wave can leave sibling requests waiting on retries. Abort the owned cancellation controller before clearing the shared deadline without cancelling the caller.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Construct explicitly typed evidence before adding the manual offer mode so the backup fixture keeps no throughput-mode property.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bk201-
Dmitrii Shilov (bk201-) force-pushed the dev/dshilov/account-overview-07-coda-freshness branch from 9666dd4 to 9002d2a Compare November 19, 2026 17:24
Copilot AI balanced review requested due to automatic review settings November 19, 2026 17:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for these changes.

No open issues 🎉

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants