Repository navigation
[7/9] Add an independent CODA freshness advisory check - #3572
Dmitrii Shilov (bk201-) wants to merge 12 commits into
Conversation
✅ Build (Compile, Lint, Prettier, l10n, Package)🧱 Step Results
📥 Artifacts (run)None |
Integration Tests
|
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/vitest
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
🧪 Unit Tests🧪 Results
📈 Coverage |
🎭 E2E Tests (Playwright + VS Code)🧪 Result
📥 Artifacts (run)
|
ecca3ec to
b4fd81e
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the read-only CODA freshness check.
No open issues 🎉
What changed in this PR
Adds a read-only freshness check alongside the pinned CODA conformance tooling, comparing the configured branch HEAD with the immutable pin without repinning or executing upstream code.
Changes:
- Reports exact ahead/behind counts and distinguishes equal, rewound, divergent, unrelated, and unverifiable histories.
- Adds an independent optional advisory job, currently disabled for all hosted triggers, with private credentials withheld from every pull request.
- Adds synthetic local-Git tests and contributor documentation for local usage and hosted behavior.
| File | Description |
|---|---|
scripts/check-coda-freshness.test.mjs |
Tests history relationships, failure handling, cleanup, credential handling, and workflow safeguards. |
scripts/check-coda-freshness.mjs |
Implements read-only comparison, reporting, and exit statuses using a disposable bare repository. |
package.json |
Adds coda:check and includes freshness tests in the CODA tooling suite. |
CONTRIBUTING.md |
Documents freshness results, local usage, and the hosted pause and credential restrictions. |
.github/workflows/package-feed.yml |
Renames the workflow and adds the paused, independent CODA freshness job. |
Review effort: Balanced
784ced4 to
5d996f2
Compare
5d996f2 to
3a84a66
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Optional cost enrichment lacks an overall cancellable deadline, so long server-directed retry delays can block the entire advisory response instead of returning unavailable cost coverage.
1 open issue
1 resolved since last review
Review effort: Balanced
3a84a66 to
70c1867
Compare
dd5cacb to
02c84de
Compare
02c84de to
9c0eff1
Compare
9c0eff1 to
9666dd4
Compare
Compare the upstream branch and immutable pin with exact history relationships, retain explicit failures, and withhold private-source credentials from all pull-request runs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the local checker and authentication intact while server-side private-source verification is not needed. Mark the independent hosted job skipped for all triggers and document the pause with regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Batch backup storage metrics and skip dependent queries for empty log sources while preserving independent checks. Handle Kusto empty-write aggregates and case-folded Monitor dimensions. Normalize Cost Management retry-after headers for the existing SDK retry policy, preserving its attempt limits and cancellation. Add regression coverage and update the overview specification. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Historical deleted-container series could consume the wildcard query limit and hide fresh storage evidence for current containers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Database-grouped requests were awaited serially, multiplying storage collection latency. Restore waves of five reads while retaining per-request identity and cross-wave snapshot checks, and stop later waves and pricing on failure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bound ARM retry waits, Monitor reads and retail pagination together without retrying before the server allows it; retain qualitative findings and categorized timeout coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Check the shared deadline before backup preconditions and ensure an hours-long retry never postpones qualitative findings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document the intentionally disabled hosted job while retaining the local freshness command. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
An early failed storage wave can leave sibling requests waiting on retries. Abort the owned cancellation controller before clearing the shared deadline without cancelling the caller. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Construct explicitly typed evidence before adding the manual offer mode so the backup fixture keeps no throughput-mode property. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
9666dd4 to
9002d2a
Compare

Summary
Compare the configured CODA branch HEAD with the immutable pin without repinning or executing upstream code. Report exact ahead/behind counts and distinguish rewound, divergent, unrelated and unverifiable histories.
The package-feed workflow gains an independent optional freshness job. Hosted execution is temporarily paused for all triggers with
if: ${{ false }}until server-side verification and private-source access are needed. The job is skipped, not reported as current. Localnpm run coda:check, token support and the existing isolation of private credentials from all pull requests remain unchanged. Includes synthetic local-Git tests and contributor documentation. Required-check settings are unchanged.Stack
Part 7 of 9 in the Account Overview advisory stack. Depends on #3571. Base: dev/dshilov/account-overview-06-coda-conformance.
Each subsequent PR targets its predecessor branch so GitHub can represent the chain as a native PR stack.
Validation
The temporary-pause follow-up passed oxfmt, full lint, all TypeScript build targets and all unit suites, using VITEST_MAX_WORKERS=2. A workflow regression test verifies the explicit pause and retained credential isolation. No user-facing strings changed.
The original worktree remains preserved in the local snapshot; this follow-up intentionally pauses only hosted CODA execution.