fix: stop pinning react/react-router/react-query requiredVersion - #82
Merged
Merged
Conversation
cloud-portal's host now ships react-router 8.3.1; this plugin's
federation config still required ^7.0.0 for the shared singleton,
which made Module Federation refuse to bridge react-router (and
cascade into react-dom/client) at runtime — a hard crash in the
browser console, not just a warning:
[Federation Runtime] shared singleton module react-router does not
satisfy the requirement of assistant.miloapis.com which needs ^7.0.0
[Module Federation] Failed to bridge external shared module
"react-dom/client" ... React error #527
The host's own federation-host.ts already declares these shared
singletons with requiredVersion: false ("host copy always wins,
regardless of the plugin's own version"); this plugin should match
that instead of enforcing a version constraint the host doesn't
honor. A version bump (matching compute's recent fix for the same
bug, ^7.0.0 -> ^8.0.0) would only defer the same crash to the host's
next major bump.
scotwells
approved these changes
Sep 11, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The plugin now shows up in cloud-portal's registry (previous blockers all resolved), but fails to actually render — the browser console shows:
```
[Federation Runtime] shared singleton module react-router does not satisfy
the requirement of assistant.miloapis.com which needs ^7.0.0
[Module Federation] Failed to bridge external shared module "react-dom/client"
... React error #527
```
cloud-portal's host now ships
react-router@8.3.1; this plugin's Module Federation config still hard-required^7.0.0, so MF refuses to bridge the shared module at all — a hard crash, not a warning.Fix
Set
requiredVersion: falsefor react/react-dom/react-router/@tanstack/react-query, matching what the host's ownfederation-host.tshostShared()already declares for these singletons ("host copy always wins"), and matching how this same file already treats@datum-cloud/portal-plugin-sdkand the datum-ui subset. compute hit and fixed this identical bug recently by bumping its pin^7.0.0 -> ^8.0.0— that only defers the same crash to the host's next major bump;falsecan't drift again.Test plan
bun run typecheck/bun run buildpass