feat: implement GroupMembership admission webhook to enforce existence and uniqueness constraints - #771
Open
JoseSzycho wants to merge 1 commit into
Open
feat: implement GroupMembership admission webhook to enforce existence and uniqueness constraints#771JoseSzycho wants to merge 1 commit into
JoseSzycho wants to merge 1 commit into
Conversation
…e and uniqueness constraints
JoseSzycho
requested review from
drewr,
mattdjenkinson and
scotwells
and removed request for
scotwells
September 3, 2026 13:36
JoseSzycho
enabled auto-merge
September 3, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
This PR introduces a validating admission webhook for
GroupMembership(iam.miloapis.com/v1alpha1) and an end-to-end Chainsaw test suite to enforce relational integrity, uniqueness, and immutability constraints.Motivation & Background
A
GroupMembershipresource models an association between a cluster-scopedUserand a namespacedGroup. Previously, there were no admission checks verifying whether the targetUserorGroupexisted, whether a duplicate membership had already been created in the namespace, or whether an existing membership was modified after creation.This webhook addresses these gaps by validating invariants at admission time and rejecting invalid create and update requests with descriptive
field.ErrorListerrors.Related to: