Skip to content

docs: remove outdated DSPy notebook and fix Dify authentication - #1596

Merged
jaelgu merged 1 commit into
milvus-io:masterfrom
zc277584121:fix/dify-auth-remove-outdated-dspy
Oct 21, 2026
Merged

jaelgu merged 1 commit into
milvus-io:masterfrom
zc277584121:fix/dify-auth-remove-outdated-dspy

Conversation

@zc277584121

Copy link
Copy Markdown
Collaborator

Description

Remove the outdated DSPy notebook, which imports MilvusRM and openai_embedding_function from a module removed upstream. Fix the Dify local deployment guide to provide credentials for the bundled Milvus service, which enables authentication by default.

Changes

  • Delete integration/milvus_and_DSPy.ipynb.
  • Set MILVUS_TOKEN=root:Milvus in the Dify example and explain the credential format and replacement of initial credentials. The Dify change is limited to two lines.

How to Test

  • git diff --cached --check passed before committing.
  • Checked tracked text files for references to the removed notebook; no remaining references were found.
  • Reviewed the Dify change against its upstream Compose authentication default. Full deployment was not run; no executable code was added or modified.

Checklist

  • Documentation changes reviewed.
  • Based on the latest upstream master at the time of the change.
  • Commit includes DCO sign-off.

Related PRs

Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jaelgu

jaelgu commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@jaelgu
jaelgu added this pull request to the merge queue Oct 21, 2026
@sre-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaelgu, zc277584121

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Merged via the queue into milvus-io:master with commit b2be8cc Oct 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants