Repository navigation
Improve MLXChatExample app - #474
Closed
DePasqualeOrg wants to merge 5 commits into
Closed
DePasqualeOrg wants to merge 5 commits into
DePasqualeOrg wants to merge 5 commits into
Conversation
Member
It is unfortunate that the examples has to pick only one provider. Ugh. |
davidkoski
reviewed
May 7, 2026
| container, | ||
| instructions: Self.systemPrompt, | ||
| history: history, | ||
| generateParameters: generateParameters, |
davidkoski
reviewed
May 7, 2026
| INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight"; | ||
| INFOPLIST_KEY_UISupportedInterfaceOrientations_iPhone = "UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight"; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 18.0; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 26.0; |
Member
There was a problem hiding this comment.
I don't think it is a problem to update the targets for the examples, but is it required?
Contributor
Author
There was a problem hiding this comment.
This is due to an issue with Liquid Glass: you need .sharedBackgroundVisibility(.hidden) to remove the glass background from indicators in the toolbar. It also allows for using Liquid Glass in the tool call/results view in the subsequent PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for a subsequent PR demonstrating the model output parsing and Open Responses streaming enabled by Swift LM Response Parser, I've fixed many issues in the MLXChatExample app. In order to keep the diff relatively small, I'm deliberately not solving every issue and not covering every edge case, since this is an example app and not meant for production. But these changes represent a significant improvement: