Bug 2053531 - Add nimbus-fml lint - #7563
Merged
Merged
Conversation
jeddai
reviewed
Aug 26, 2026
freshstrangemusic
left a comment
freshstrangemusic
left a comment
Member
There was a problem hiding this comment.
I agree with charlie about using a trait for lints and then we can have a Vec<Box<&dyn Linter>> or smth and call the lints from each member.
Adds a lint command covering feature metadata, descriptions, naming and feature design, and a `no-lint` field to silence lints per feature or per file. `validate` no longer reports feature metadata warnings; that's the lint command's job now.
The per-module check calls in `lint_module` were a list a new module of lints could be left out of. `define_categories!` now declares each category with the linter that owns it, so registration is a compile error instead of a silent no-op. Also from review: `subject` -> `group` in `output_findings`, reworded the invalid manifest error, s/when/if in a doc comment, changelog under `Nimbus`.
Dedupes `is_boolean` and the lint name width, drops the `no_lint` alias, and trims comments that restated the code. Adds coverage for object fields, enum variants, the summary counts, `--list`, an invalid manifest, and that every lint is tripped by a fixture.
travis79
force-pushed
the
Bug2053531
branch
from
September 17, 2026 12:13
98d7bd8 to
c32d923
Compare
freshstrangemusic
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a lint command covering feature metadata, descriptions, naming and feature design, and a
no-lintfield to silence lints per feature or per file.validateno longer reports feature metadata warnings; that's the lint command's job now.Pull Request checklist
[ci full]to the PR title.