Bug 2069243 - Add the containers component - #7577
Merged
Merged
Conversation
bakulf
force-pushed
the
containers
branch
2 times, most recently
from
September 2, 2026 22:36
0efa8a8 to
0713de6
Compare
bakulf
force-pushed
the
containers
branch
2 times, most recently
from
September 4, 2026 07:35
15cb50c to
38b3ec6
Compare
bendk
approved these changes
Sep 4, 2026
bendk
left a comment
Contributor
There was a problem hiding this comment.
I don't know enough about the containers code to really review this, so I mostly focused on general Rust component issues.
bakulf
force-pushed
the
containers
branch
3 times, most recently
from
September 18, 2026 14:35
623f8c6 to
16ba90f
Compare
jonalmeida
approved these changes
Sep 22, 2026
jonalmeida
left a comment
Collaborator
There was a problem hiding this comment.
I walked through the code myself locally and it looks fine to me. I don't have a strong sense of what is good rust style these days, but it's good start either way.
We synced on this patch and these are my take-away notes:
- The l10n IDs will be removed in a future iteration because they are desktop only and cannot link to Android.
- A syncable future is separate, but we don't want to combine this component with an existing syncable storage like remote_tabs because it will use a different sync machine for this store.
- Icons and colours need to be generated on the frontend side of the platforms to be used there, and we link them with a shared ID.
- This is an in-memory copy of the containers, and the platforms will push and pull the list from here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.