Repository navigation
Conversation
theidkamp
force-pushed
the
cvv-column
branch
2 times, most recently
from
September 28, 2026 12:54
2d70a5d to
1fb5140
Compare
theidkamp
force-pushed
the
cvv-column
branch
from
September 28, 2026 13:14
1fb5140 to
b96c146
Compare
5 tasks
theidkamp
force-pushed
the
theidkamp/pr-7573
branch
from
October 2, 2026 08:52
6156f4a to
637e469
Compare
theidkamp
force-pushed
the
theidkamp/pr-7573
branch
from
October 2, 2026 08:56
637e469 to
5071768
Compare
A v6 schema upgrade adds the cc_cvv_enc column; the field is transparent like the number - cleartext cc_cvv in, decrypted cc_cvv out, optional in both directions. It syncs as a new optional cc-cvv payload field; records written by older clients round-trip it through the mirror's unknown-fields handling, so their edits do not drop it.
theidkamp
force-pushed
the
theidkamp/pr-7573
branch
from
October 2, 2026 09:53
5071768 to
54fc561
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #7573 (base is
theidkamp/pr-7573What
https://bugzilla.mozilla.org/show_bug.cgi?id=2076154
Bug 2076154: Store an optional CVV encrypted alongside the card number, handled exactly like the number:
cc_cvv_enc(ALTER TABLE ... ADD COLUMN, no data rewrite - existing rows simply have no CVV; same encoding and blank-marker rules ascc_number_enc).UpdatableCreditCardFields.cc_cvv(cleartext in, optional, defaults to none - so this is not breaking for consumers) andCreditCard.cc_cvv(decrypted out).Noneand an empty string both mean "no CVV".Pull Request checklist