Skip to content

fix: pass the publish_existing_tag input to the recovery step through env - #1977

Merged
n24q02m merged 1 commit into
mainfrom
fix/cd-dispatch-input-env
Nov 17, 2026
Merged

n24q02m merged 1 commit into
mainfrom
fix/cd-dispatch-input-env

Conversation

@n24q02m

@n24q02m n24q02m commented Nov 17, 2026

Copy link
Copy Markdown
Owner

The recovery step (Use existing tag (immutable-release recovery)) interpolated ${{ inputs.publish_existing_tag }} directly into its run: script. GitHub expands ${{ }} into the script text before the shell parses it, so a dispatch input was treated as shell code.

The value now reaches the script through the step env: as PUBLISH_EXISTING_TAG, and the script reads the variable. Behaviour for a normal tag such as v1.2.3 does not change.

Checks: actionlint passes on the changed workflow, and no run: block in cd.yml or ci.yml interpolates inputs.* or github.event.* any more.

… env

The recovery step interpolated ${{ inputs.publish_existing_tag }} straight into its run script. GitHub expands ${{ }} into the script text before the shell parses it, so a dispatch input was shell code there. The value now reaches the script as an environment variable.
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@n24q02m
n24q02m merged commit 713a6ed into main Nov 17, 2026
14 checks passed
@n24q02m
n24q02m deleted the fix/cd-dispatch-input-env branch November 17, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant