Repository navigation
fix: pass the publish_existing_tag input to the recovery step through env - #1977
Merged
Merged
Conversation
… env
The recovery step interpolated ${{ inputs.publish_existing_tag }} straight into its run script. GitHub expands ${{ }} into the script text before the shell parses it, so a dispatch input was shell code there. The value now reaches the script as an environment variable.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recovery step (
Use existing tag (immutable-release recovery)) interpolated${{ inputs.publish_existing_tag }}directly into itsrun:script. GitHub expands${{ }}into the script text before the shell parses it, so a dispatch input was treated as shell code.The value now reaches the script through the step
env:asPUBLISH_EXISTING_TAG, and the script reads the variable. Behaviour for a normal tag such asv1.2.3does not change.Checks:
actionlintpasses on the changed workflow, and norun:block incd.ymlorci.ymlinterpolatesinputs.*orgithub.event.*any more.