Repository navigation
Enable MPS for dorado polish on macOS ARM64 - #1638
Open
DylanCosto wants to merge 1 commit into
Open
DylanCosto wants to merge 1 commit into
DylanCosto wants to merge 1 commit into
Conversation
dorado polish only accepted 'cpu' or CUDA devices, and on Metal builds 'auto' resolved to the CPU. Accept 'metal'/'mps' (Torch MPS, budgeting half of the unified memory for batch sizing) and make 'auto' select it on Metal builds. E. coli ONT 51x, Flye draft (4.88 Mb), dna_r10.4.1_e8.2_400bps_sup@v5.2.0_polish_rl, M4 Pro: whole draft 1729s on the CPU (official 2.1.2 release) vs 274.5s on the GPU; 1 Mb region median of 3: 339.4s vs 63.6s. The consensus is identical to the CPU in both cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable MPS acceleration for
dorado polishon macOS ARM64. Accept--device metal/mps, select MPS for--device auto, and budget half of shared host memory. Changes are guarded byDORADO_METAL_BUILD.macOS ARM64: E. coli reads aligned to a Flye draft, v5.2 read-level model.
Consensus FASTA is byte-identical between CPU and MPS for both workloads.
Linux x86-64 CPU/CUDA regression checks also pass with byte-identical consensus to baseline (HG003 ONT chr20, 20 kb; v5.0 read-level model).