Skip to content

chore: remove the object store compatibility responder - #526

Open
aricart wants to merge 2 commits into
mainfrom
remove-os-compat
Open

aricart wants to merge 2 commits into
mainfrom
remove-os-compat

Conversation

@aricart

@aricart aricart commented Nov 18, 2026

Copy link
Copy Markdown
Member

this is the old compatibility test harness - we don't need this anymore right @Jarema?
we can prune this and just do the new mechanism. This removes some deps and things.

@aricart
aricart requested a review from Jarema November 18, 2026 19:32
@synadia-claude-reviewer

synadia-claude-reviewer Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @aricart's task in 31s —— View job


Review: remove object store compatibility responder

  • Fetch PR diff and description
  • Check for dangling references to removed files/deps
  • Review correctness, security, and TS/runtime concerns
  • Post final review summary

Summary: Clean, self-contained deletion of the old bin/os_compatibility.ts test harness, its bin/docker/Dockerfile, and the now-unused @chiefbiiko/sha256 dependency (removed from deno.json and the special-case mapping in bin/dependencies.ts).

Verification:

  • No remaining references to os_compatibility, bin/docker, or chiefbiiko anywhere in the repo, including .github/workflows/* — nothing else invokes the deleted Dockerfile or script.
  • The js-sha256 usage in obj/src/sha256.ts is a separate, independently-maintained dependency and is unaffected by this change.
  • bin/dependencies.ts edit is just removing the special-case URL mapping for the now-gone dep; the rest of the dependency-scanning logic is untouched and still correct.

No correctness, security, or type issues — this is purely dead-code/dependency removal with zero behavioral surface in the shipped packages (bin/ is tooling only, not part of core/jetstream/kv/obj/services).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant