Skip to content

fix(ci): release action could be triggered concurrently - #528

Open
aricart wants to merge 1 commit into
mainfrom
release-concurrency
Open

aricart wants to merge 1 commit into
mainfrom
release-concurrency

Conversation

@aricart

@aricart aricart commented Nov 18, 2026

Copy link
Copy Markdown
Member

No description provided.

@synadia-claude-reviewer

synadia-claude-reviewer Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @aricart's task in 1m 12s —— View job


Review complete

  • Fetch PR diff and description
  • Review .github/workflows/npm.yml concurrency change
  • Review bin/npm-publish.sh E409 handling
  • Post review summary

Summary: Minimal, well-scoped fix. The concurrency group on release-${{ github.ref }} correctly serializes duplicate release runs instead of letting them race on npm publish, and cancel-in-progress: false is the right call so an in-flight publish isn't killed. The npm-publish.sh change correctly captures npm publish's combined output/exit status and treats E409 (version already published by the other run) as a skip rather than a failure — the existing npm view pre-check plus this fallback together cover the registry-propagation-lag case well.

One gap worth confirming with the author: concurrency + cancel-in-progress: false means a duplicate run now executes sequentially after the first one finishes, rather than being cancelled. By that point Publish JSR (deno publish --allow-dirty at .github/workflows/npm.yml:57) runs again for a version JSR has already published. If deno publish hard-fails on a duplicate version (unlike the new npm handling), the duplicate run's job will still end up red at that earlier step — npm-publish.sh's new E409 tolerance would never even be reached in that scenario, since the job fails before Publish NPM runs. Worth verifying deno publish's behavior on a duplicate version, or scoping the fix title/description to "avoids npm races" specifically if JSR duplicate-publish isn't in scope.

Minor/non-blocking: grep -q "E409" (bin/npm-publish.sh:20) is a loose substring match on npm's combined stdout/stderr; tightening to "npm error code E409" would reduce (very unlikely) false-positive risk from unrelated error text.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant