You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(ci): release action could be triggered concurrently - #528
Summary: Minimal, well-scoped fix. The concurrency group on release-${{ github.ref }} correctly serializes duplicate release runs instead of letting them race on npm publish, and cancel-in-progress: false is the right call so an in-flight publish isn't killed. The npm-publish.sh change correctly captures npm publish's combined output/exit status and treats E409 (version already published by the other run) as a skip rather than a failure — the existing npm view pre-check plus this fallback together cover the registry-propagation-lag case well.
One gap worth confirming with the author: concurrency + cancel-in-progress: false means a duplicate run now executes sequentially after the first one finishes, rather than being cancelled. By that point Publish JSR (deno publish --allow-dirty at .github/workflows/npm.yml:57) runs again for a version JSR has already published. If deno publish hard-fails on a duplicate version (unlike the new npm handling), the duplicate run's job will still end up red at that earlier step — npm-publish.sh's new E409 tolerance would never even be reached in that scenario, since the job fails before Publish NPM runs. Worth verifying deno publish's behavior on a duplicate version, or scoping the fix title/description to "avoids npm races" specifically if JSR duplicate-publish isn't in scope.
Minor/non-blocking: grep -q "E409" (bin/npm-publish.sh:20) is a loose substring match on npm's combined stdout/stderr; tightening to "npm error code E409" would reduce (very unlikely) false-positive risk from unrelated error text.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.