Repository navigation
Documentation improvement: description of kernel parameters and randomness in NEST GPU - #141
Merged
Merged
Conversation
jhnnsnk
requested changes
Sep 18, 2026
jhnnsnk
left a comment
jhnnsnk
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! I left a few suggestions for improvement, mostly about adding cross-references to NEST Simulator.
Co-authored-by: Johanna Senk <jhnnsnk@users.noreply.github.com>
Collaborator
Author
|
@jhnnsnk thanks a lot for your suggestions, I've implemented them in the current version! |
jhnnsnk
requested changes
Sep 29, 2026
jhnnsnk
left a comment
jhnnsnk
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but could you please also add the default values to all the other kernel parameters?
Collaborator
Author
|
Hi @jhnnsnk, I've added the default values for all the kernel parameters, thanks for pointing this out! PS sorry for the numerous commits, but I had to getting used to the new CI checks :) |
Collaborator
Author
|
As discussed in our last meeting, I'll merge the PR since I've added the default values for kernel parameters. |
Collaborator
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two guides to the documentation: one on randomness in NEST GPU (i.e., the description of the rng seed and how to distribute neuron and synapse parameters in NEST GPU) and one describing the current set of kernel parameters.
Fork documentation version available at the following link: https://nest-gpu-fork.readthedocs.io/en/documentation/guides/index.html