Repository navigation
Ebola resources page - #1400
Ebola resources page#1400jameshadfield wants to merge 3 commits into
Conversation
| * Core build paths whose bare URL (e.g. `/ebola`) should _not_ be handled here | ||
| * but instead fall through to the Next.js static site, which serves a bespoke | ||
| * landing page at that path. | ||
| */ | ||
| const staticPagePaths = new Set([ | ||
| "/ebola", |
There was a problem hiding this comment.
+1 for this pattern instead of /sars-cov-2 vs. /ncov. I always found that a bit weird.
| * landing page at that path. | ||
| */ | ||
| const staticPagePaths = new Set([ | ||
| "/ebola", |
There was a problem hiding this comment.
I was able to find references to /ebola in GH search and the /pathogens page also uses the default link.
Thoughts on using a different path, e.g./ebola-resources, instead of replacing the default /ebola URL?
There was a problem hiding this comment.
Thanks for digging here! I think all of those are resolvable (and should be done as part of this). I agree with Victor's comment above; where we have lots of foo/* builds I think having a splash page at /foo makes the most sense.
There was a problem hiding this comment.
I've updated the files flagged by that GH search in our docs repo, narratives and the ebola repo itself. (Many of them were bugs right now!) The auspice narrative i'll leave, as narratives there aren't used for anything, so I need to sort them out as part of a bigger push. The link in the augur repo will actually be better once this PR is merged as going to an ebolavirus splash page is the better behaviour.
I'll look into the /pathogens page now...
Closes <#1389> Claude Opus 4.8 helped write the tiles list component code. All text & design decisions were mine.
This reverts commit 0cbdbc8. Recommended in PR review <#1400 (comment)>
f0b657d to
298b4f5
Compare
This branch was successfully deployed
3 participants
Closes #1389
Review app main splash page
Review app /ebola splash page