Skip to content

onevcs: Checks must remain readable for pull requests from forks #626

Open

Description

@nickderobertis

Root cause

Check visibility must resolve required checks in the repository that owns the pull request. Instead, requests from forks can be read in the fork’s context, where the pull request number does not exist, so managers cannot read their checks or release holdups.

Impact

Who is affected. Managers and contributors using onevcs in the conditions described below.

What it costs them. Managers following checks on fork pull requests lose the check and holdup answer in that situation.

What it costs the product owner. Managers following checks on fork pull requests lose the check and holdup answer in that situation. No measured dollar spend or weekly subscription quota loss is established.

Cost of the workaround.

  • Applying it: Read the pull request’s checks directly on GitHub while the automated read is unavailable.

  • Side effects on the outcome: Automated visibility is replaced by manual inspection.

  • Discovery: The failed automated answer does not identify this workaround; a manager must recognize the condition and investigate.

  • Severity: high

  • Workaround: Read the pull request’s checks directly on GitHub while the automated read is unavailable.

  • Severity with the workaround: medium

  • Priority estimate: high (severity with the workaround medium; fires consistently; 1 occurrence; raised one level because it fires consistently)

Examples

GitHub answered NOT_FOUND at the required-check field for python/cpython#161186; the null node accompanies data. The basis still selects the head reference.

Suggested fix

Read the rollup through the pull request’s last commit connection in its owning repository, keeping required-check classification and all shared consumers on that same pull request context.

Contributing locations.

  • onevcs crates/onevcs/src/standings/github.rs: The shared rollup selection follows the head reference and asks whether checks are required using the base repository’s pull request number; lines 90–93, 826 and 867.

onevcs — github.com/nickderobertis/onevcs

Check standings, follow reads and release holdups return check classifications for fork pull requests under the same contract as same-repository pull requests; no CLI change.

Owning runs

Visible-check-failures-for-managers

Evidence

Host: lima-hp.

GitHub answered NOT_FOUND at the required-check field for python/cpython#161186; the null node accompanies data. The basis still selects the head reference.

Basis github.com/nickderobertis/onevcs: bd6e108.

Draft drafts:Visible-check-failures-for-managers/drafts/20261102T180520Z-standings-follow-and-holdup-reads-fail-on-a-pull; run Visible-check-failures-for-managers; author node, node onevcs-check-visibility-2. Transcript: onepipeline transcript Visible-check-failures-for-managers onevcs-check-visibility-2. Verified locations and line references are listed under Suggested fix.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions