Skip to content

feat: refactor HTML component CSS scoping - #1457

Merged
AliKdhim87 merged 2 commits into
mainfrom
refactor/html-component-css-scoping
Sep 22, 2026
Merged

AliKdhim87 merged 2 commits into
mainfrom
refactor/html-component-css-scoping

Conversation

@AliKdhim87

Copy link
Copy Markdown
Contributor

issue: #1293

@AliKdhim87
AliKdhim87 requested a review from a team as a code owner September 21, 2026 09:08
@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
candidate Ready Ready Preview Sep 21, 2026 2:15pm UTC
candidate-storybook-non-conforming Ready Ready Preview Sep 21, 2026 2:15pm UTC
candidate-storybook-test Ready Ready Preview Sep 21, 2026 2:15pm UTC

Request Review

@codecov-commenter

codecov-commenter commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (758d0a0) to head (68d98fc).
⚠️ Report is 134 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1457   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        20    +2     
  Lines          138       146    +8     
  Branches        30        30           
=========================================
+ Hits           138       146    +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Robbert Robbert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks! One optimization though

Comment thread packages/components-css/heading-css/src/vanilla/heading.scss Outdated
@AliKdhim87
AliKdhim87 force-pushed the refactor/html-component-css-scoping branch from 9ad90db to fa7b14c Compare September 21, 2026 14:00
@AliKdhim87
AliKdhim87 requested a review from Robbert September 21, 2026 14:01
@sonarqubecloud

Copy link
Copy Markdown

@AliKdhim87 AliKdhim87 linked an issue Sep 22, 2026 that may be closed by this pull request
@AliKdhim87
AliKdhim87 merged commit d64859d into main Sep 22, 2026
16 checks passed
@AliKdhim87
AliKdhim87 deleted the refactor/html-component-css-scoping branch September 22, 2026 07:50

This branch was successfully deployed

3 active deployments
Preview – candidate-storybook-non-conforming 68d98fcf Deployed Sep 21, 2026 by vercel[bot]
Preview – candidate-storybook-test 68d98fcf Deployed Sep 21, 2026 by vercel[bot]
Preview – candidate 68d98fcf Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nl-html voor Candidate componenten

3 participants