v8: include Android trap handler sources - #65774
Open
luoqianlin wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
luoqianlin
force-pushed
the
android-v8-trap-handler-sources
branch
from
September 4, 2026 12:35
50ba292 to
3bd87a6
Compare
luoqianlin
force-pushed
the
android-v8-trap-handler-sources
branch
from
September 4, 2026 12:39
3bd87a6 to
d9f1c2d
Compare
Signed-off-by: luoqianlin <qianlinluo@foxmail.com>
luoqianlin
force-pushed
the
android-v8-trap-handler-sources
branch
from
September 4, 2026 12:46
d9f1c2d to
98da35b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the V8 POSIX trap-handler sources needed by Android cross-builds to be
compiled without enabling the Android trap handler.
Android remains explicitly unsupported for trap-handler activation because its
signal and crash-reporting behavior requires a separate security review. This
change adds the required POSIX source files, including the host simulator
helper needed by arm64-on-x64 configurations. It does not enable trap-handler
activation on Android, and the existing V8 Android safety guard remains
unchanged.
NDK r29 with Android API 30 and arm64 is the current validation baseline.
Refs: #65771
Validation:
git diff --checkV8_TRAP_HANDLER_SUPPORTEDremains false for Android native andarm64-on-x64 simulator configurations.