benchmark: throw on invalid type in fs and webstorage

benchmark/error/error.js

@@ -9,6 +9,7 @@ const bench = common.createBenchmark(main, {
 function main({ n }) {
   bench.start();
   for (let i = 0; i < n; ++i)
+    // eslint-disable-next-line no-restricted-syntax
     new Error('test');
   bench.end(n);
 }

benchmark/fs/bench-accessSync.js

@@ -48,7 +48,7 @@ function main({ n, type, method }) {
       path = tmpdir.resolve(`.non-existing-file-${process.pid}`);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 
   if (method === 'access') {

benchmark/fs/bench-chmodSync.js

@@ -36,6 +36,6 @@ function main({ n, type }) {
       bench.end(n);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }

benchmark/fs/bench-chownSync.js

@@ -49,6 +49,6 @@ function main({ n, type, method }) {
       break;
     }
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }

benchmark/fs/bench-existsSync.js

@@ -27,7 +27,7 @@ function main({ n, type }) {
       path = tmpdir.resolve(`.non-existing-file-${process.pid}`);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 
   bench.start();

benchmark/fs/bench-fchmodSync.js

@@ -28,7 +28,7 @@ function main({ n, type }) {
       files = new Array(n).fill(tmpdir.resolve(`.non-existing-file-${Date.now()}`));
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 
   const fds = files.map((x) => {

benchmark/fs/bench-fsyncSync.js

@@ -24,7 +24,7 @@ function main({ n, type }) {
       fd = 1 << 30;
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 
   bench.start();

benchmark/fs/bench-linkSync.js

@@ -45,6 +45,6 @@ function main({ n, type }) {
       break;
     }
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }

benchmark/fs/bench-mkdirSync.js

@@ -29,7 +29,7 @@ function main({ n, type, recursive }) {
       files = new Array(n).fill(__dirname);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 
   bench.start();

benchmark/fs/bench-mkdtempSync.js

@@ -27,7 +27,7 @@ function main({ n, type }) {
       prefix = tmpdir.resolve('non-existent', 'foo', 'bar');
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 
   bench.start();

benchmark/fs/bench-openSync.js

@@ -33,7 +33,7 @@ function main({ n, type }) {
       path = tmpdir.resolve(`.non-existing-file-${process.pid}`);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 
   runBench({ n, path });

benchmark/fs/bench-opendirSync.js

@@ -25,7 +25,7 @@ function main({ n, type }) {
       files = [tmpdir.resolve(`.non-existing-file-${Date.now()}`)];
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 
   bench.start();

benchmark/fs/bench-readSync.js

@@ -38,7 +38,7 @@ function main({ n, type }) {
       fd = 1 << 30;
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 
   const buffer = Buffer.alloc(bufferSize);

benchmark/fs/bench-readlinkSync.js

@@ -49,6 +49,6 @@ function main({ n, type }) {
       break;
     }
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }

benchmark/fs/bench-rmdirSync.js

@@ -37,6 +37,6 @@ function main({ n, type }) {
       break;
     }
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }

benchmark/fs/bench-symlinkSync.js

@@ -46,6 +46,6 @@ function main({ n, type }) {
       break;
     }
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }

benchmark/fs/bench-timesSync.js

@@ -56,6 +56,6 @@ function main({ n, type, func }) {
       break;
     }
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }

benchmark/fs/bench-unlinkSync.js

@@ -28,7 +28,7 @@ function main({ n, type }) {
       files = new Array(n).fill(tmpdir.resolve(`.non-existing-file-${Date.now()}`));
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 
   bench.start();

benchmark/fs/bench_fdatasyncSync.js

@@ -24,7 +24,7 @@ function main({ n, type }) {
       fd = 1 << 30;
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 
   bench.start();

benchmark/webstorage/getItem.js

@@ -70,6 +70,6 @@ function main({ n, type }) {
       bench.end(n);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }

benchmark/webstorage/removeItem.js

@@ -70,6 +70,6 @@ function main({ n, type }) {
       bench.end(n);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }

benchmark/webstorage/setItem.js

@@ -58,6 +58,6 @@ function main({ n, type }) {
       bench.end(n);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }

test/parallel/test-errors-systemerror.js

@@ -7,6 +7,7 @@ const { E, SystemError, codes, kIsNodeError } = require('internal/errors');
 const { inspect } = require('internal/util/inspect');
 
 assert.throws(
+  // eslint-disable-next-line no-restricted-syntax
   () => { new SystemError(); },
   {
     name: 'TypeError',

tools/eslint/eslint.config_utils.mjs

@@ -16,6 +16,10 @@ export const noRestrictedSyntaxCommonAll = [
     selector: 'ThrowStatement > CallExpression[callee.name=/Error$/]',
     message: 'Use `new` keyword when throwing an `Error`.',
   },
+  {
+    selector: 'ExpressionStatement > NewExpression[callee.name=/Error$/]',
+    message: 'Throw, return, or assign the `Error`; constructing it alone does nothing.',
+  },
   {
     selector: "CallExpression[callee.property.name='substr']",
     message: 'Use String.prototype.slice() or String.prototype.substring() instead of String.prototype.substr()',